Bug 85097

Summary: [V8] Implement a helper method V8Proxy::throwNotEnoughArgumentsError()
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84074    
Attachments:
Description Flags
Patch
none
Patch
haraken: commit-queue-
patch for landing none

Kentaro Hara
Reported 2012-04-27 13:53:55 PDT
In bug 84787, kbr requested to avoid hard-coding throwError("Not enough arguments", V8Proxy::TypeError) here and there. In this bug we implement V8Proxy::throwNotEnoughArgumentsError() and use it in V8 bindings. I'll write another patch for JSC bindings.
Attachments
Patch (9.42 KB, patch)
2012-04-27 14:13 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (9.52 KB, patch)
2012-04-27 14:15 PDT, Kentaro Hara 		haraken: commit-queue-
DetailsFormatted DiffDiff
patch for landing (40.96 KB, patch)
2012-04-27 15:39 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-04-27 14:13:56 PDT
Created attachment 139274 [details] Patch
Kentaro Hara
Comment 2 2012-04-27 14:15:23 PDT
Created attachment 139276 [details] Patch
Kenneth Russell
Comment 3 2012-04-27 14:56:31 PDT
Comment on attachment 139276 [details] Patch Looks good. r=me
Kentaro Hara
Comment 4 2012-04-27 15:39:39 PDT
Comment on attachment 139276 [details] Patch Forgot to update run-bindings-tests results...
Kentaro Hara
Comment 5 2012-04-27 15:39:48 PDT
Created attachment 139294 [details] patch for landing
WebKit Review Bot
Comment 6 2012-04-27 18:00:06 PDT
Comment on attachment 139294 [details] patch for landing Clearing flags on attachment: 139294 Committed r115522: <http://trac.webkit.org/changeset/115522>
Note You need to log in before you can comment on or make changes to this bug.