Bug 84956

Summary: Add copy constructor to CSSSelector
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77745    
Attachments:
Description Flags
patch
webkit-ews: commit-queue-
fix build andersca: review+

Antti Koivisto
Reported 2012-04-26 07:37:44 PDT
Top copy CSSSelectorList correctly CSSSelector needs a copy constructor.
Attachments
patch (6.91 KB, patch)
2012-04-26 07:43 PDT, Antti Koivisto 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
fix build (6.96 KB, patch)
2012-04-26 08:04 PDT, Antti Koivisto 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2012-04-26 07:43:43 PDT
Created attachment 139001 [details] patch
WebKit Review Bot
Comment 2 2012-04-26 07:46:21 PDT
Attachment 139001 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/CSSSelector.h:40: The parameter name "o" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/css/CSSSelector.h:246: The parameter name "o" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexis Menard (darktears)
Comment 3 2012-04-26 07:50:12 PDT
Comment on attachment 139001 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=139001&action=review > Source/WebCore/ChangeLog:8 > + To copy CSSSelectorLists correctly CSSSelector needs a copy constructor. Maybe you should explain the why, the real objective in this first patch.
Early Warning System Bot
Comment 4 2012-04-26 07:59:30 PDT
Comment on attachment 139001 [details] patch Attachment 139001 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12530950
Build Bot
Comment 5 2012-04-26 08:04:22 PDT
Comment on attachment 139001 [details] patch Attachment 139001 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12543094
Antti Koivisto
Comment 6 2012-04-26 08:04:53 PDT
Created attachment 139003 [details] fix build
Antti Koivisto
Comment 7 2012-04-26 08:56:54 PDT
http://trac.webkit.org/changeset/115319
Note You need to log in before you can comment on or make changes to this bug.