Bug 84536

Summary: Add test function to get placeholder string
Product: WebKit Reporter: Kent Tamura <tkent>
Component: Tools / TestsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, morrita, pnormand, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 83872    
Attachments:
Description Flags
Cooked on EWS
none
Patch
none
Patch 2
none
Patch 3
none
Patch for landing none

Kent Tamura
Reported 2012-04-21 10:34:13 PDT
Add test function to get placeholder string
Attachments
Cooked on EWS (7.47 KB, patch)
2012-04-21 10:41 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch (16.11 KB, patch)
2012-04-22 18:18 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 2 (16.11 KB, patch)
2012-04-22 18:26 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 3 (15.04 KB, patch)
2012-04-22 19:07 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.71 KB, patch)
2012-04-22 22:35 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-04-21 10:41:52 PDT
Created attachment 138246 [details] Cooked on EWS
Build Bot
Comment 2 2012-04-21 11:05:47 PDT
Comment on attachment 138246 [details] Cooked on EWS Attachment 138246 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12469509
Build Bot
Comment 3 2012-04-21 11:08:21 PDT
Comment on attachment 138246 [details] Cooked on EWS Attachment 138246 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12476465
Philippe Normand
Comment 4 2012-04-21 11:09:57 PDT
Comment on attachment 138246 [details] Cooked on EWS Attachment 138246 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12476468
Kent Tamura
Comment 5 2012-04-22 18:18:02 PDT
Created attachment 138282 [details] Patch
Philippe Normand
Comment 6 2012-04-22 18:23:03 PDT
Comment on attachment 138282 [details] Patch Attachment 138282 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12482698
Kent Tamura
Comment 7 2012-04-22 18:26:41 PDT
Created attachment 138283 [details] Patch 2 GTK fix?
Build Bot
Comment 8 2012-04-22 18:54:33 PDT
Comment on attachment 138283 [details] Patch 2 Attachment 138283 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12477683
Kent Tamura
Comment 9 2012-04-22 19:07:16 PDT
Created attachment 138284 [details] Patch 3 Attempt to fix Windows build
Ryosuke Niwa
Comment 10 2012-04-22 21:51:52 PDT
Comment on attachment 138284 [details] Patch 3 View in context: https://bugs.webkit.org/attachment.cgi?id=138284&action=review > Source/WebCore/testing/Internals.cpp:397 > + if (!element->hasTagName(inputTag) && !element->hasTagName(textareaTag)) > + return String(); > + HTMLTextFormControlElement* textControl = toTextFormControl(element); toTextFormControl returns 0 when it's not a text from control element. So you can just do: if (!textControl || !textControl->placeholderShouldBeVisible()) return String(); > LayoutTests/fast/forms/placeholder-stripped-expected.txt:9 > +PASS internals.visiblePlaceholder(input0) is "first line second line" > +PASS internals.visiblePlaceholder(input1) is "" > +PASS internals.visiblePlaceholder(textarea0) is "first line second line" > +PASS internals.visiblePlaceholder(textarea1) is "" Should we explicitly test a case when we the place holder is invisible?
Kent Tamura
Comment 11 2012-04-22 22:27:31 PDT
(In reply to comment #10) > toTextFormControl returns 0 when it's not a text from control element. So you can just do: > if (!textControl || !textControl->placeholderShouldBeVisible()) > return String(); You're right. I'll update the code and land it by CQ. > > > LayoutTests/fast/forms/placeholder-stripped-expected.txt:9 > > +PASS internals.visiblePlaceholder(input0) is "first line second line" > > +PASS internals.visiblePlaceholder(input1) is "" > > +PASS internals.visiblePlaceholder(textarea0) is "first line second line" > > +PASS internals.visiblePlaceholder(textarea1) is "" > > Should we explicitly test a case when we the place holder is invisible? The original test doesn't have intention to test it.
Kent Tamura
Comment 12 2012-04-22 22:35:12 PDT
Created attachment 138292 [details] Patch for landing
WebKit Review Bot
Comment 13 2012-04-23 01:00:30 PDT
Comment on attachment 138292 [details] Patch for landing Clearing flags on attachment: 138292 Committed r114877: <http://trac.webkit.org/changeset/114877>
WebKit Review Bot
Comment 14 2012-04-23 01:00:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.