Bug 84496

Summary: Clean up subpixel unit handling in hit testing code
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, leviw, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch
none
Patch none

Emil A Eklund
Reported 2012-04-20 14:40:38 PDT
We currently use IntRect where we should use LayoutRect and the other way around in a couple of places.
Attachments
Patch (4.72 KB, patch)
2012-04-20 14:51 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch (4.82 KB, patch)
2012-04-23 10:26 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2012-04-20 14:51:57 PDT
Created attachment 138170 [details] Patch
Eric Seidel (no email)
Comment 2 2012-04-20 15:49:08 PDT
Comment on attachment 138170 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138170&action=review > Source/WebCore/ChangeLog:9 > + Fix use of IntRect and LayoutRect in hit testing code in preparation for > + subpixel layout. Why?
Emil A Eklund
Comment 3 2012-04-20 16:57:53 PDT
(In reply to comment #2) > Why? I really should expand on that, thanks for pointing it out.
Emil A Eklund
Comment 4 2012-04-23 10:26:07 PDT
Created attachment 138377 [details] Patch
Eric Seidel (no email)
Comment 5 2012-04-23 11:03:53 PDT
Comment on attachment 138377 [details] Patch I guess hit testing results are currently IntRects, so this isn't really a change. I'm just slightly surprised we wouldnt' want them to be LayoutRects.
Emil A Eklund
Comment 6 2012-04-23 11:07:02 PDT
(In reply to comment #5) > (From update of attachment 138377 [details]) > I guess hit testing results are currently IntRects, so this isn't really a change. I'm just slightly surprised we wouldnt' want them to be LayoutRects. Eventually we do want to move hit testing to LayoutUnits/Rects. I would prefer changing one system at a time though.
Emil A Eklund
Comment 7 2012-04-23 12:02:15 PDT
Committed r114926: <http://trac.webkit.org/changeset/114926>
Note You need to log in before you can comment on or make changes to this bug.