Bug 84417

Summary: [Chromium] Remove PlatformSupport::loadPlatformImageResource, call loadResource directly
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: WebKit Misc.Assignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cc-bugs, fishd, haraken, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82948    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Mark Pilgrim (Google)
Reported 2012-04-19 20:27:27 PDT
[Chromium] Remove PlatformSupport::loadPlatformImageResource, call loadResource directly
Attachments
Patch (5.12 KB, patch)
2012-04-19 20:28 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (7.95 KB, patch)
2012-05-09 07:44 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (7.94 KB, patch)
2012-05-09 11:57 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2012-04-19 20:28:04 PDT
Created attachment 138035 [details] Patch
Mark Pilgrim (Google)
Comment 2 2012-04-19 20:29:09 PDT
Duplicates some code between ImageChromium.cpp and ImageChromiumMac.mm. Problem?
Kentaro Hara
Comment 3 2012-04-20 01:16:57 PDT
Comment on attachment 138035 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138035&action=review > Duplicates some code between ImageChromium.cpp and ImageChromiumMac.mm. Problem? Yeah, we want to avoid duplication. > Source/WebCore/platform/graphics/chromium/ImageChromiumMac.mm:41 > +#include <public/Platform.h> Nit: This header is duplicated.
Mark Pilgrim (Google)
Comment 4 2012-05-09 07:44:58 PDT
Created attachment 140943 [details] Patch
Mark Pilgrim (Google)
Comment 5 2012-05-09 07:46:04 PDT
After discussion with abarth, this new patch removes ImageChromiumMac.mm and all references in build scripts, thus eliminating the duplicate code problem.
Adam Barth
Comment 6 2012-05-09 09:08:27 PDT
Comment on attachment 140943 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140943&action=review > Source/WebCore/platform/graphics/chromium/ImageChromium.cpp:51 > + return image; image.release(); ^^ Transfers the reference from the RefPtr to the PassRefPtr, saving an increment and a decrement on the refcount.
Mark Pilgrim (Google)
Comment 7 2012-05-09 11:57:52 PDT
Created attachment 140988 [details] Patch
Mark Pilgrim (Google)
Comment 8 2012-05-09 11:58:22 PDT
(In reply to comment #6) > (From update of attachment 140943 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=140943&action=review > > > Source/WebCore/platform/graphics/chromium/ImageChromium.cpp:51 > > + return image; > > image.release(); > ^^ Transfers the reference from the RefPtr to the PassRefPtr, saving an increment and a decrement on the refcount. Included in latest patch.
WebKit Review Bot
Comment 9 2012-05-09 15:05:45 PDT
Comment on attachment 140988 [details] Patch Clearing flags on attachment: 140988 Committed r116561: <http://trac.webkit.org/changeset/116561>
WebKit Review Bot
Comment 10 2012-05-09 15:05:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.