Bug 83278

Summary: Update LayoutUnit usage in Editor and Frame
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: eae, eric, jchaffraix, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch
none
Patch none

Levi Weintraub
Reported 2012-04-05 07:31:04 PDT
Both have functions that are taking LayoutUnit coordinates that represent screen coordinates. These should be Ints.
Attachments
Patch (5.33 KB, patch)
2012-04-05 07:41 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Patch (6.16 KB, patch)
2012-04-05 09:14 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2012-04-05 07:41:44 PDT
Created attachment 135822 [details] Patch
Build Bot
Comment 2 2012-04-05 08:08:32 PDT
Comment on attachment 135822 [details] Patch Attachment 135822 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12340349
Build Bot
Comment 3 2012-04-05 08:21:18 PDT
Comment on attachment 135822 [details] Patch Attachment 135822 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12264329
Levi Weintraub
Comment 4 2012-04-05 09:14:27 PDT
Created attachment 135837 [details] Patch
Levi Weintraub
Comment 5 2012-04-06 08:59:30 PDT
Friendly neighborhood "ping" :)
WebKit Review Bot
Comment 6 2012-04-06 11:35:06 PDT
Comment on attachment 135837 [details] Patch Clearing flags on attachment: 135837 Committed r113466: <http://trac.webkit.org/changeset/113466>
WebKit Review Bot
Comment 7 2012-04-06 11:35:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.