Bug 83169

Summary: Update LayoutUnit usage in RenderInputSpeech::paintInputFieldSpeechButton
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: dglazkov, eae, eric, jchaffraix, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch
webkit.review.bot: commit-queue-
Patch2 none

Levi Weintraub
Reported 2012-04-04 09:05:12 PDT
Called from RenderTheme code, and therefor with an IntRect, we need to make sure we handle variables from the render tree properly.
Attachments
Patch (3.49 KB, patch)
2012-04-04 09:48 PDT, Levi Weintraub 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch2 (3.49 KB, patch)
2012-04-04 10:59 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2012-04-04 09:48:36 PDT
Created attachment 135613 [details] Patch Not yet requesting a review since this isn't enabled on Apple's Mac port. I want to see this pass the Chromium EWS bot to ensure the refactoring is correct first.
WebKit Review Bot
Comment 2 2012-04-04 10:52:41 PDT
Comment on attachment 135613 [details] Patch Attachment 135613 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12320971
Levi Weintraub
Comment 3 2012-04-04 10:59:54 PDT
Created attachment 135628 [details] Patch2 Now with 100% fewer compiler errors?
Levi Weintraub
Comment 4 2012-04-05 06:33:20 PDT
My patch had some refactoring, but the main issue is resolved. *** This bug has been marked as a duplicate of bug 83089 ***
Note You need to log in before you can comment on or make changes to this bug.