Bug 82946

Summary: Rename GraphicsContext::drawLineForTextChecking() to GraphicsContext::drawLineForDocumentMarker()
Product: WebKit Reporter: Jia Pu <jiapu.mail>
Component: New BugsAssignee: Jia Pu <jiapu.mail>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.7   
Bug Depends on:    
Bug Blocks: 82503    
Attachments:
Description Flags
Patch (V1)
none
Fixed a typo. none

Jia Pu
Reported 2012-04-02 14:25:22 PDT
On OSX, we draw similar underline on dictated text that has alternative text. We should rename this function, so that we can reuse it with dictation.
Attachments
Patch (V1) (14.78 KB, patch)
2012-04-02 16:44 PDT, Jia Pu 		no flags
DetailsFormatted DiffDiff
Fixed a typo. (14.78 KB, patch)
2012-04-03 09:02 PDT, Jia Pu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jia Pu
Comment 1 2012-04-02 14:37:12 PDT
<rdar://problem/11169336>
Jia Pu
Comment 2 2012-04-02 16:44:28 PDT
Created attachment 135227 [details] Patch (V1)
Mark Rowe (bdash)
Comment 3 2012-04-02 19:43:57 PDT
It is OS X, not OSX.
Simon Fraser (smfr)
Comment 4 2012-04-02 19:51:36 PDT
Comment on attachment 135227 [details] Patch (V1) View in context: https://bugs.webkit.org/attachment.cgi?id=135227&action=review > Source/WebCore/ChangeLog:8 > + On OSX, we draw similar underline on dictated text that has alternative text. We rename OS X
Jia Pu
Comment 5 2012-04-03 09:02:04 PDT
Created attachment 135338 [details] Fixed a typo.
Enrica Casucci
Comment 6 2012-04-03 10:16:21 PDT
Comment on attachment 135338 [details] Fixed a typo. Looks good.
WebKit Review Bot
Comment 7 2012-04-03 10:43:03 PDT
Comment on attachment 135338 [details] Fixed a typo. Clearing flags on attachment: 135338 Committed r113059: <http://trac.webkit.org/changeset/113059>
WebKit Review Bot
Comment 8 2012-04-03 10:43:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.