Bug 82863

Summary: [chromium] Disable ENABLE_INPUT_TYPE_COLOR for aura and android
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: peter, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Keishi Hattori
Reported 2012-04-02 00:37:07 PDT
Disable ENABLE_INPUT_TYPE_COLOR for aura and android. I turned them on by mistake but the UIs aren't ready.
Attachments
Patch (1.22 KB, patch)
2012-04-02 00:46 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (1.57 KB, patch)
2012-04-02 01:18 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (1.58 KB, patch)
2012-04-02 02:01 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (1.58 KB, patch)
2012-04-02 02:04 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2012-04-02 00:46:13 PDT
Created attachment 135037 [details] Patch
Peter Beverloo
Comment 2 2012-04-02 00:54:08 PDT
Comment on attachment 135037 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135037&action=review Have you tested this? This will define ENABLE_INPUT_TYPE_COLOR multiple times, which will cause compiler warnings. Output for an Android build: <command-line>: warning: "ENABLE_INPUT_TYPE_COLOR" redefined <command-line>: warning: this is the location of the previous definition Disabling this feature for Android LGTM, at least until the Chromium-side implementation is complete. > Source/WebKit/chromium/features.gypi:141 > + 'feature_defines': [ nit: indenting.
Peter Beverloo
Comment 3 2012-04-02 00:57:16 PDT
Comment on attachment 135037 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135037&action=review > Source/WebKit/chromium/features.gypi:140 > + ['OS=="android" or use_aura==1',{ one more nit: space after the comma.
Keishi Hattori
Comment 4 2012-04-02 01:18:36 PDT
Created attachment 135039 [details] Patch
Keishi Hattori
Comment 5 2012-04-02 01:20:10 PDT
(In reply to comment #2) > (From update of attachment 135037 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135037&action=review > > Have you tested this? This will define ENABLE_INPUT_TYPE_COLOR multiple times, which will cause compiler warnings. Output for an Android build: Sorry. I didn't have an android or aura build environment.
Peter Beverloo
Comment 6 2012-04-02 01:47:56 PDT
Comment on attachment 135039 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135039&action=review Thank you! There's one more thing you'll want to adjust, namely that Mac is being excluded now instead of Android. Deferring to tkent/a reviewer now :-). > Source/WebKit/chromium/features.gypi:139 > + ['OS=="mac" or use_aura==1', { s/mac/android/
Keishi Hattori
Comment 7 2012-04-02 02:01:25 PDT
Created attachment 135045 [details] Patch
Keishi Hattori
Comment 8 2012-04-02 02:04:43 PDT
Created attachment 135046 [details] Patch
Kent Tamura
Comment 9 2012-04-02 02:16:03 PDT
Comment on attachment 135046 [details] Patch ok
WebKit Review Bot
Comment 10 2012-04-02 03:20:43 PDT
Comment on attachment 135046 [details] Patch Clearing flags on attachment: 135046 Committed r112849: <http://trac.webkit.org/changeset/112849>
WebKit Review Bot
Comment 11 2012-04-02 03:20:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.