Bug 82574

Summary: [BlackBerry] Add m_targetType to WorkerScriptLoader
Product: WebKit Reporter: Leo Yang <leo.yang>
Component: WebKit BlackBerryAssignee: Leo Yang <leo.yang>
Status: RESOLVED FIXED    
Severity: Normal CC: charles.wei, rwlbuis, staikos, tonikitoo, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73144    
Attachments:
Description Flags
Patch none

Leo Yang
Reported 2012-03-28 23:30:43 PDT
Just as Chromium porting BlackBerry porting is using m_targetType also.
Attachments
Patch (1.77 KB, patch)
2012-03-28 23:32 PDT, Leo Yang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Leo Yang
Comment 1 2012-03-28 23:32:45 PDT
Created attachment 134508 [details] Patch
Charles Wei
Comment 2 2012-03-29 00:30:14 PDT
Comment on attachment 134508 [details] Patch How did it pass the compile before this patch for BB porting?
Leo Yang
Comment 3 2012-03-29 00:49:26 PDT
(In reply to comment #2) > (From update of attachment 134508 [details]) > How did it pass the compile before this patch for BB porting? What do you mean "before this patch"?
Leo Yang
Comment 4 2012-03-29 01:10:23 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 134508 [details] [details]) > > How did it pass the compile before this patch for BB porting? > > What do you mean "before this patch"? If you mean "How did it pass the compile without this patch for BB porting?", the answer is that for internal build the change has been there; for upstreaming build we definitely can't pass compile because there are lots of things to be upstreamed.
Rob Buis
Comment 5 2012-03-29 04:16:50 PDT
Comment on attachment 134508 [details] Patch Ok.
WebKit Review Bot
Comment 6 2012-03-29 05:32:06 PDT
Comment on attachment 134508 [details] Patch Clearing flags on attachment: 134508 Committed r112521: <http://trac.webkit.org/changeset/112521>
WebKit Review Bot
Comment 7 2012-03-29 05:32:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.