Bug 82535

Summary: Change FilterOperations::getOutsets to use integers
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, krit, leviw, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318, 83041    
Attachments:
Description Flags
Patch none

Emil A Eklund
Reported 2012-03-28 15:04:05 PDT
FilterOperations::getOutsets calculates the outset based on integers and then upcasts the values to LayoutUnits.
Attachments
Patch (5.39 KB, patch)
2012-03-28 15:08 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2012-03-28 15:08:38 PDT
Created attachment 134413 [details] Patch
Eric Seidel (no email)
Comment 2 2012-03-28 15:47:07 PDT
Comment on attachment 134413 [details] Patch Ha! Yes, these make no sense as LayoutUnits. :)
Dirk Schulze
Comment 3 2012-03-28 15:51:30 PDT
wouldn't it be easier to replace the 4 ints by one IntRect?
Emil A Eklund
Comment 4 2012-03-28 15:56:05 PDT
(In reply to comment #3) > wouldn't it be easier to replace the 4 ints by one IntRect? Would be easier but as the numbers don't really represent a rectangle it would be a bit confusing. Perhaps we need some new data type for things like borders, outsets, margins and paddings where you have a value for each edge.
WebKit Review Bot
Comment 5 2012-03-28 16:57:32 PDT
Comment on attachment 134413 [details] Patch Clearing flags on attachment: 134413 Committed r112475: <http://trac.webkit.org/changeset/112475>
WebKit Review Bot
Comment 6 2012-03-28 16:57:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.