Bug 82047

Summary: [CSS Regions] CSS Regions enabled by default on Windows
Product: WebKit Reporter: Ion Rosca <rosca>
Component: CSSAssignee: Ion Rosca <rosca>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: adele, donggwan.kim, hyatt, jberlin, mibalan, rosca, sfalken, shanestephens, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Windows 7   
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
First patch
buildbot: commit-queue-
win fix eric: review+

Ion Rosca
Reported 2012-03-23 05:07:11 PDT
CSS Regions - cannot be switched on/off through Windows WebKit COM interface. - cannot be switched on/off using a runtime flag in javascript. - should be enabled by default All these problems were solved on mac ( https://bugs.webkit.org/show_bug.cgi?id=78525 )
Attachments
First patch (3.37 KB, patch)
2012-03-23 05:30 PDT, Ion Rosca 		buildbot: commit-queue-
DetailsFormatted DiffDiff
win fix (3.94 KB, patch)
2012-03-23 08:08 PDT, Ion Rosca 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ion Rosca
Comment 1 2012-03-23 05:30:42 PDT
Created attachment 133466 [details] First patch
Build Bot
Comment 2 2012-03-23 06:41:28 PDT
Comment on attachment 133466 [details] First patch Attachment 133466 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12120643
Ion Rosca
Comment 3 2012-03-23 08:08:52 PDT
Created attachment 133488 [details] win fix
Jessie Berlin
Comment 4 2012-03-23 13:07:26 PDT
Comment on attachment 133488 [details] win fix This patch does not enable CSS Regions by default. It just adds WK1 API to enable CSS Regions. To enable it by default, you would have to add a line in Source/WebKit/win/WebPreferences.cpp that sets the default to true. However, I am not sure that it is desirable to turn CSS Regions on by default on Windows.
Ion Rosca
Comment 5 2012-03-23 14:33:41 PDT
(In reply to comment #4) > (From update of attachment 133488 [details]) > This patch does not enable CSS Regions by default. It just adds WK1 API to enable CSS Regions. To enable it by default, you would have to add a line in Source/WebKit/win/WebPreferences.cpp that sets the default to true. > > However, I am not sure that it is desirable to turn CSS Regions on by default on Windows. The default true worked for me beeing set in Source\WebKit2\Shared\WebPreferencesStore.h, which is not platform specific. Mac as well has no specific default value for CSS Regions. We could continue without adding default value in WebPreferences.cpp. Is it ok?
Eric Seidel (no email)
Comment 6 2012-04-19 16:23:54 PDT
Comment on attachment 133488 [details] win fix Seems reasonable. I agree with Jessie, it's not clear to me that CSS regions should be enabled by default on Win. That's really a decision for Apple.
Mihai Balan
Comment 7 2012-11-22 07:09:11 PST
Actually a duplicate of #89430 that was long gone fixed :) *** This bug has been marked as a duplicate of bug 89430 ***
Note You need to log in before you can comment on or make changes to this bug.