Bug 81775

Summary: Correct LayoutUnit usage in VisiblePosition.cpp
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: eae, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch none

Levi Weintraub
Reported 2012-03-21 06:29:19 PDT
There's currently a mismatched function definition, and we assign localCaretRect to an IntRect, when local coordinates should be LayoutUnits.
Attachments
Patch (2.50 KB, patch)
2012-03-21 06:46 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2012-03-21 06:46:04 PDT
Created attachment 133035 [details] Patch
Eric Seidel (no email)
Comment 2 2012-03-21 11:15:07 PDT
Comment on attachment 133035 [details] Patch OK. Caret rects will be sub-pixel precise?
Levi Weintraub
Comment 3 2012-03-21 15:32:37 PDT
Comment on attachment 133035 [details] Patch Thanks Eric :)
WebKit Review Bot
Comment 4 2012-03-21 15:42:42 PDT
Comment on attachment 133035 [details] Patch Clearing flags on attachment: 133035 Committed r111613: <http://trac.webkit.org/changeset/111613>
WebKit Review Bot
Comment 5 2012-03-21 15:42:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.