Bug 81746
| Summary: | REGRESSION (r111497): fast/css/text-transform-select.html and fast/forms/select/menulist-disabled-option.html is failing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | mitz |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dglazkov, keishi, ossy, pnormand, shinyak, tkent, webkit-bug-importer, yosin |
| Priority: | P1 | Keywords: | InRadar, LayoutTestFailure, Regression |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 79764 | ||
mitz
After <http://trac.webkit.org/r111500>, text-transform is not applied to the popup button text in fast/css/text-transform-select.html.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/11088942>
mitz
Updated the Mac expected results for this test in <http://trac.webkit.org/r111508>.
Csaba Osztrogonác
r111497 is the culprit, not r111500.
- http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r111527%20%2835221%29/fast/css/text-transform-select-pretty-diff.html
- http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r111527%20%2835221%29/fast/forms/select/menulist-disabled-option-diffs.html
These tests fail on Qt,GTK, Chromium too.
GTK guys landed failing expected result for it - http://trac.webkit.org/changeset/111513/trunk/LayoutTests/platform/gtk/fast/css/text-transform-select-expected.txt
and Chromium guys did it too - http://trac.webkit.org/changeset/111506
Csaba Osztrogonác
Just a question: Why don't we simple rollout r111497 and let the author fix the regression caused by his patch? We make extra work for us if we commit failing expected files, skip failing tests, etc.
Csaba Osztrogonác
(In reply to comment #4)
> Just a question: Why don't we simple rollout r111497 and let the author fix the regression caused by his patch? We make extra work for us if we commit failing expected files, skip failing tests, etc.
Rolled out with gardenings too - http://trac.webkit.org/changeset/111532. (rs=Philipp)
mitz
(In reply to comment #5)
> (In reply to comment #4)
> > Just a question: Why don't we simple rollout r111497 and let the author fix the regression caused by his patch? We make extra work for us if we commit failing expected files, skip failing tests, etc.
>
> Rolled out with gardenings too - http://trac.webkit.org/changeset/111532. (rs=Philipp)
Thanks. Is there a reason why you didn’t change this bug’s status to Resolved?
Csaba Osztrogonác
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > Just a question: Why don't we simple rollout r111497 and let the author fix the regression caused by his patch? We make extra work for us if we commit failing expected files, skip failing tests, etc.
> >
> > Rolled out with gardenings too - http://trac.webkit.org/changeset/111532. (rs=Philipp)
>
> Thanks. Is there a reason why you didn’t change this bug’s status to Resolved?
Yes, I forgot it. :)