Bug 81595

Summary: webkitpy: clean up some port._filesystem references to not reference private members
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 71380    
Attachments:
Description Flags
Patch
none
fix nit in write_image_diff_files() as well eric: review+

Dirk Pranke
Reported 2012-03-19 16:54:54 PDT
webkitpy: clean up some port._filesystem references to not reference private members
Attachments
Patch (11.64 KB, patch)
2012-03-19 16:55 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
fix nit in write_image_diff_files() as well (11.77 KB, patch)
2012-03-19 17:01 PDT, Dirk Pranke 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-03-19 16:55:31 PDT
Created attachment 132722 [details] Patch
Dirk Pranke
Comment 2 2012-03-19 17:01:23 PDT
Created attachment 132725 [details] fix nit in write_image_diff_files() as well
Eric Seidel (no email)
Comment 3 2012-03-19 17:16:58 PDT
Comment on attachment 132725 [details] fix nit in write_image_diff_files() as well View in context: https://bugs.webkit.org/attachment.cgi?id=132725&action=review OK. > Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:71 > - if port.host.filesystem.exists(expected_filename): > + if self._filesystem.exists(expected_filename): In general getting away from using "port" for these sorts of things seems good. The goal being to make "port" less of the hub/god object.
Dirk Pranke
Comment 4 2012-03-19 18:26:03 PDT
Committed r111289: <http://trac.webkit.org/changeset/111289>
Note You need to log in before you can comment on or make changes to this bug.