Bug 81477

Summary: CSS3 calc: make mask images work with mixed percent/absolute
Product: WebKit Reporter: Mike Lawther <mikelawther>
Component: New BugsAssignee: Mike Lawther <mikelawther>
Status: RESOLVED FIXED    
Severity: Normal CC: macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 16662    
Attachments:
Description Flags
Patch none

Mike Lawther
Reported 2012-03-18 17:50:10 PDT
CSS3 calc: make mask images work with mixed percent/absolute
Attachments
Patch (5.00 KB, patch)
2012-03-18 17:52 PDT, Mike Lawther 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike Lawther
Comment 1 2012-03-18 17:52:34 PDT
Created attachment 132514 [details] Patch
Mike Lawther
Comment 2 2012-03-18 17:54:34 PDT
For your reviewing pleasure, this is the testcase that is now passing: http://trac.webkit.org/browser/trunk/LayoutTests/css3/calc/simple-composited-mask.html Just linking it here since it doesn't show up in the review as the test itself is unchanged.
Ojan Vafai
Comment 3 2012-03-19 10:23:13 PDT
Comment on attachment 132514 [details] Patch Sigh. So much duplicate code. It's not your fault though. If you wanted to do a cleanup patch after this, you could move the duplicated code in mapFillSize into a static helper function (i.e. lines 4230-4239 are identical to 4241-4250). r=me if you decide to do that.
WebKit Review Bot
Comment 4 2012-03-19 11:02:53 PDT
Comment on attachment 132514 [details] Patch Clearing flags on attachment: 132514 Committed r111205: <http://trac.webkit.org/changeset/111205>
WebKit Review Bot
Comment 5 2012-03-19 11:02:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.