Bug 81027

Summary: [EFL] Enable HTML5 Summary and Details elements
Product: WebKit Reporter: Thiago Marcos P. Santos <tmpsantos>
Component: WebKit EFLAssignee: Thiago Marcos P. Santos <tmpsantos>
Status: RESOLVED FIXED    
Severity: Normal CC: d-r, gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, naginenis, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 79900    
Bug Blocks:    
Attachments:
Description Flags
Enables Details and Summary elements. none

Thiago Marcos P. Santos
Reported 2012-03-13 13:12:26 PDT
Looks like this feature is enabled for all ports, except EFL. I see no reason for that.
Attachments
Enables Details and Summary elements. (100.24 KB, patch)
2012-03-13 15:47 PDT, Thiago Marcos P. Santos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thiago Marcos P. Santos
Comment 1 2012-03-13 13:14:21 PDT
Added dependency since some of the tests for validating the feature depends on window.internals.
Thiago Marcos P. Santos
Comment 2 2012-03-13 15:47:38 PDT
Created attachment 131736 [details] Enables Details and Summary elements.
Gyuyoung Kim
Comment 3 2012-03-13 17:31:52 PDT
It seems to me there is no critical problem to support ENALBE(DETAILS) on EFL port. Could you let me know a result of layout test after this patch ?
Thiago Marcos P. Santos
Comment 4 2012-03-13 23:00:28 PDT
(In reply to comment #3) > It seems to me there is no critical problem to support ENALBE(DETAILS) on EFL port. > > Could you let me know a result of layout test after this patch ? On my machine (Ubuntu 11.10 + EFL-svn), all the tests I removed from the skip list on this patch are passing now. I tested rendering some Summary/Details code examples with Chromium 17, GtkLauncher and EWebLauncher. The results were all the same, at least for my poor colorblind eyes. :)
WebKit Review Bot
Comment 5 2012-03-14 10:32:45 PDT
Comment on attachment 131736 [details] Enables Details and Summary elements. Clearing flags on attachment: 131736 Committed r110713: <http://trac.webkit.org/changeset/110713>
WebKit Review Bot
Comment 6 2012-03-14 10:32:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.