Bug 80820

Summary: [BlackBerry] Upstream the BlackBerry change to platform/graphics/FontPlatformData.h
Product: WebKit Reporter: Leo Yang <leo.yang>
Component: WebKit BlackBerryAssignee: Leo Yang <leo.yang>
Status: RESOLVED FIXED    
Severity: Normal CC: charles.wei, rwlbuis, staikos, tonikitoo, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73144    
Attachments:
Description Flags
Patch
none
Patch v2 none

Leo Yang
Reported 2012-03-12 01:01:48 PDT
This is the BlackBerry specific change to platform/graphics/FontPlatformData.h. It's using the FontPlatformData from chromium.
Attachments
Patch (1.79 KB, patch)
2012-03-12 01:28 PDT, Leo Yang 		no flags
DetailsFormatted DiffDiff
Patch v2 (1.83 KB, patch)
2012-03-12 01:38 PDT, Leo Yang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Leo Yang
Comment 1 2012-03-12 01:28:25 PDT
Created attachment 131291 [details] Patch
WebKit Review Bot
Comment 2 2012-03-12 01:31:33 PDT
Attachment 131291 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/FontPlatformData.h:39: "chromium/FontPlatformData.h" already included at Source/WebCore/platform/graphics/FontPlatformData.h:27 [build/include] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Leo Yang
Comment 3 2012-03-12 01:38:48 PDT
Created attachment 131294 [details] Patch v2 Satisfying the style bot.
Rob Buis
Comment 4 2012-03-12 08:53:51 PDT
Comment on attachment 131294 [details] Patch v2 LGTM.
Leo Yang
Comment 5 2012-03-12 18:36:13 PDT
Comment on attachment 131294 [details] Patch v2 Sending to the cq...
WebKit Review Bot
Comment 6 2012-03-12 19:17:47 PDT
Comment on attachment 131294 [details] Patch v2 Clearing flags on attachment: 131294 Committed r110528: <http://trac.webkit.org/changeset/110528>
WebKit Review Bot
Comment 7 2012-03-12 19:17:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.