Bug 80762

Summary: VCSUtils.pm doesn't support SVN 1.7 diff files
Product: WebKit Reporter: Ashod Nakashian <ashodnakashian>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, dbates, ddkilzer, eric, ssandela, vivekgalatage
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch and unit tests none

Ashod Nakashian
Reported 2012-03-10 11:39:48 PST
VCSUtils.pm doesn't support SVN 1.7 diff files. In particular, SVN properties aren't completely supported and the 1.7 version specific markers aren't supported at all. This bug is to address this issue, adding support for SVN 1.7 diff files as much as reasonably possible. Specifically, the following FIXME in VCSUtils.pm:1007 is to be addressed: # FIXME: We should expand this code to support other properties. In the future, # parseSvnDiffProperties may return a hash whose keys are the properties.
Attachments
Patch and unit tests (17.83 KB, patch)
2012-10-08 22:47 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2012-10-08 22:47:55 PDT
Created attachment 167692 [details] Patch and unit tests
Eric Seidel (no email)
Comment 2 2012-10-08 23:03:17 PDT
Comment on attachment 167692 [details] Patch and unit tests Seems reasonable to me, but I feel neither a perl nor svn expert. If you need a more detailed review, I recommend you find one. :)
Daniel Bates
Comment 3 2012-10-08 23:13:20 PDT
(In reply to comment #0) > [...] > This bug is to address this issue, adding support for SVN 1.7 diff files as much as reasonably possible. Specifically, the following FIXME in VCSUtils.pm:1007 is to be addressed: > > > # FIXME: We should expand this code to support other properties. In the future, > # parseSvnDiffProperties may return a hash whose keys are the properties. This FIXME is to implement support for recognizing additional SVN properties (*). It isn't necessary to fix this FIXME to support SVN 1.7 formatted diffs. Filed <https://bugs.webkit.org/show_bug.cgi?id=98723> to recognize additional SVN properties. (*) Currently, we only recognize the property svn:executable.
Daniel Bates
Comment 4 2012-10-08 23:13:42 PDT
*** Bug 80104 has been marked as a duplicate of this bug. ***
Daniel Bates
Comment 5 2012-10-09 13:36:07 PDT
Comment on attachment 167692 [details] Patch and unit tests Clearing flags on attachment: 167692 Committed r130805: <http://trac.webkit.org/changeset/130805>
Daniel Bates
Comment 6 2012-10-09 13:36:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.