Bug 80497

Summary: Add support for ENABLE(LEGACY_NOTIFICATIONS)
Product: WebKit Reporter: Jon Lee <jonlee>
Component: DOMAssignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, atwilson, charles.wei, rakuco, tonikitoo, vestbo, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.7   
Bug Depends on:    
Bug Blocks: 80472, 80482, 80483    
Attachments:
Description Flags
Patch
none
Patch abarth: review+

Jon Lee
Reported 2012-03-07 00:04:43 PST
Add the ENABLE_LEGACY_NOTIFICATIONS flag for all ports that currently support NOTIFICATIONS.
Attachments
Patch (36.55 KB, patch)
2012-03-07 15:50 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (36.61 KB, patch)
2012-03-07 23:01 PST, Jon Lee 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2012-03-07 00:05:14 PST
<rdar://problem/11001341>
Jon Lee
Comment 2 2012-03-07 15:50:54 PST
Created attachment 130714 [details] Patch
Martin Robinson
Comment 3 2012-03-07 22:09:40 PST
Comment on attachment 130714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130714&action=review > Source/WebCore/GNUmakefile.am:489 > +FEATURE_DEFINES += ENABLE_LEGACY_NOTIFICATIONS=1 > FEATURE_DEFINES += ENABLE_NOTIFICATIONS=1 > +webcore_cppflags += -DENABLE_LEGACY_NOTIFICATIONS=1 > webcore_cppflags += -DENABLE_NOTIFICATIONS=1 This is sort of a nit but it would be cleaner to do: FEATURE_DEFINES += ENABLE_NOTIFICATIONS=1 ENABLE_LEGACY_NOTIFICATIONS=1 webcore_cppflags += -DENABLE_NOTIFICATIONS=1 -DENABLE_LEGACY_NOTIFICATIONS=1
Jon Lee
Comment 4 2012-03-07 23:01:06 PST
Created attachment 130778 [details] Patch Incorporated Martin's feedback
Jon Lee
Comment 5 2012-03-08 12:06:33 PST
Anyone else?
Adam Barth
Comment 6 2012-03-08 14:56:17 PST
Comment on attachment 130778 [details] Patch The mechanics of this patch appear to be correct. I assume from the webkit-dev thread that you have buy-in from the folks who work on notifications that this is the right path to take.
Jon Lee
Comment 7 2012-03-08 15:20:15 PST
Committed r110217: <http://trac.webkit.org/changeset/110217>
Jon Lee
Comment 8 2012-03-09 11:43:14 PST
The commit was wrong-- it only changed the Changelogs. The real commit is r110311, and I removed the change to the Changelogs. <http://trac.webkit.org/changeset/110311>
Note You need to log in before you can comment on or make changes to this bug.