Bug 80482

Summary:

Rename notification properties and functions

Product:

WebKit

Reporter:

Jon Lee <jonlee>

Component:

DOM

Assignee:

Jon Lee <jonlee>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, haraken, ojan, webkit-bug-importer, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.7

Bug Depends on:

80497

Bug Blocks:

80472

Attachments:

Description	Flags
WIP	none
WIP #2	none
Patch	none
Patch	none
Patch	none
Patch	haraken: review+

Jon Lee

Reported 2012-03-06 21:12:57 PST

Proposal: 1. replaceId -> id 2. cancel -> close <rdar://problem/10912432>

Attachments
WIP (12.38 KB, patch) 2012-03-07 16:40 PST, Jon Lee	no flags	Details Formatted Diff Diff
WIP #2 (15.68 KB, patch) 2012-03-07 17:05 PST, Jon Lee	no flags	Details Formatted Diff Diff
Patch (19.13 KB, patch) 2012-03-08 14:05 PST, Jon Lee	no flags	Details Formatted Diff Diff
Patch (22.88 KB, patch) 2012-03-13 23:31 PDT, Jon Lee	no flags	Details Formatted Diff Diff
Patch (22.51 KB, patch) 2012-03-13 23:37 PDT, Jon Lee	no flags	Details Formatted Diff Diff
Patch (21.45 KB, patch) 2012-04-01 15:25 PDT, Jon Lee	haraken: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Jon Lee

Comment 1 2012-03-07 16:40:06 PST

Created attachment 130724 [details] WIP

Jon Lee

Comment 2 2012-03-07 17:05:34 PST

Created attachment 130729 [details] WIP #2

Kentaro Hara

Comment 3 2012-03-07 18:16:37 PST

(In reply to comment #0) > Proposal: > 1. replaceId -> id > 2. cancel -> close Is this speced? It appears that the spec uses replaceId and cancel(): http://www.w3.org/TR/notifications/

Early Warning System Bot

Comment 4 2012-03-07 18:17:30 PST

Comment on attachment 130729 [details] WIP #2 Attachment 130729 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11865047

WebKit Review Bot

Comment 5 2012-03-07 19:17:11 PST

Comment on attachment 130729 [details] WIP #2 Attachment 130729 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11867056

Jon Lee

Comment 6 2012-03-07 19:43:06 PST

(In reply to comment #3) > (In reply to comment #0) > > Proposal: > > 1. replaceId -> id > > 2. cancel -> close > > Is this speced? > > It appears that the spec uses replaceId and cancel(): > > http://www.w3.org/TR/notifications/ No this is not agreed upon in the spec yet. It's still under discussion. But I decided to post the patch up anyway to get the EWS results. Anyway, I don't intend on submitting this until there's been discussion and agreement in the WG.

Kentaro Hara

Comment 7 2012-03-07 19:45:19 PST

Comment on attachment 130729 [details] WIP #2 > No this is not agreed upon in the spec yet. It's still under discussion. But I decided to post the patch up anyway to get the EWS results. Anyway, I don't intend on submitting this until there's been discussion and agreement in the WG. OK, let me invalidate r?.

Early Warning System Bot

Comment 8 2012-03-08 00:26:56 PST

Comment on attachment 130729 [details] WIP #2 Attachment 130729 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/11865179

Jon Lee

Comment 9 2012-03-08 14:05:44 PST

Created attachment 130900 [details] Patch

Kentaro Hara

Comment 10 2012-03-08 14:11:50 PST

Comment on attachment 130900 [details] Patch r- due to no consensus on the spec. You can upload the patch with the "--no-review" option, if you do not intend to have the patch be reviewed. If you want to see the ews-bot results, you can just click "Submit for EWS analysis".

Jon Lee

Comment 11 2012-03-13 23:31:46 PDT

Created attachment 131792 [details] Patch

Jon Lee

Comment 12 2012-03-13 23:37:15 PDT

Created attachment 131793 [details] Patch

Jon Lee

Comment 13 2012-04-01 15:25:31 PDT

Created attachment 135015 [details] Patch

Jon Lee

Comment 14 2012-04-01 15:26:52 PDT

Comment on attachment 135015 [details] Patch Changes based on discussions in the WG: http://lists.w3.org/Archives/Public/public-web-notification/2012Mar/0024.html http://lists.w3.org/Archives/Public/public-web-notification/2012Mar/0013.html

Kentaro Hara

Comment 15 2012-04-01 15:32:42 PDT

The patch looks OK. (In reply to comment #14) > http://lists.w3.org/Archives/Public/public-web-notification/2012Mar/0024.html > http://lists.w3.org/Archives/Public/public-web-notification/2012Mar/0013.html Is the spec going to be updated soon (i.e. did anyone start the work)? If so, let me r+ it. I am a bit afraid that the WebKit implementation becomes inconsistent with the spec in case where no one is interested in updating the spec.

Jon Lee

Comment 16 2012-04-01 15:53:46 PDT

(In reply to comment #15) > The patch looks OK. > > (In reply to comment #14) > > http://lists.w3.org/Archives/Public/public-web-notification/2012Mar/0024.html > > http://lists.w3.org/Archives/Public/public-web-notification/2012Mar/0013.html > > Is the spec going to be updated soon (i.e. did anyone start the work)? If so, let me r+ it. I am a bit afraid that the WebKit implementation becomes inconsistent with the spec in case where no one is interested in updating the spec. To my knowledge, John is current editor of the spec, and I know he intends on updating the spec based on all the discussions the WG has had.

Kentaro Hara

Comment 17 2012-04-01 15:56:43 PDT

Comment on attachment 135015 [details] Patch OK!

Jon Lee

Comment 18 2012-04-01 16:15:57 PDT

Committed r112821: <http://trac.webkit.org/changeset/112821>

Note You need to log in before you can comment on or make changes to this bug.