Bug 80051

Summary: Update usage of LayoutUnits in InlineBox and InlineFlowBox
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eae, eric, jchaffraix, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch none

Levi Weintraub
Reported 2012-03-01 14:33:00 PST
Updating InlineFlowBox to match LayoutUnit usage in the subpixellayout branch.
Attachments
Patch (10.44 KB, patch)
2012-03-05 11:43 PST, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2012-03-05 11:43:05 PST
Created attachment 130168 [details] Patch
Eric Seidel (no email)
Comment 2 2012-03-06 17:08:11 PST
Comment on attachment 130168 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130168&action=review Looks OK. > Source/WebCore/ChangeLog:8 > + Updating LayoutUnit vs Integer usage in InlineBox and InlineFlowBox. Please explain why. I guess you did some in the individual changes below... You could even link to your fancy wiki. :) "Although the LineBox tree uses floats internally, borders/padding are caulated with LayoutUnits, like the rest of block layout in the rendering tree. See the wiki *URL* for more details."
Levi Weintraub
Comment 3 2012-03-07 10:59:52 PST
Committed r110070: <http://trac.webkit.org/changeset/110070>
Note You need to log in before you can comment on or make changes to this bug.