Bug 80026

Summary:

[EFL] Prefix run-launcher with run-with-jhbuild

Product:

WebKit

Reporter:

Dominik Röttsches (drott) <d-r>

Component:

Tools / Tests

Assignee:

Dominik Röttsches (drott) <d-r>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

pnormand, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Linux

Bug Depends on:

79673

Bug Blocks:

79480

Attachments:

Description	Flags
Run launcher under jhbuild, v1	none
Run launcher under jhbuild, v2	pnormand: review+
Run launcher under jhbuild, v3	none

Dominik Röttsches (drott)

Reported 2012-03-01 07:28:03 PST

In order for the launcher to use the jhbuild-provided EFL libaries, let's prefix it with run-with-jhbuild as well.

Attachments
Run launcher under jhbuild, v1 (1.36 KB, patch) 2012-03-15 08:25 PDT, Dominik Röttsches (drott)	no flags	Details Formatted Diff Diff
Run launcher under jhbuild, v2 (1.12 KB, patch) 2012-03-16 07:37 PDT, Dominik Röttsches (drott)	pnormand: review+	Details Formatted Diff Diff
Run launcher under jhbuild, v3 (1003 bytes, patch) 2012-03-19 02:38 PDT, Dominik Röttsches (drott)	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Dominik Röttsches (drott)

Comment 1 2012-03-15 08:25:48 PDT

Created attachment 132056 [details] Run launcher under jhbuild, v1

Dominik Röttsches (drott)

Comment 2 2012-03-16 07:37:50 PDT

Created attachment 132282 [details] Run launcher under jhbuild, v2 catfile not required, patch simplified.

Philippe Normand

Comment 3 2012-03-19 02:27:00 PDT

Comment on attachment 132282 [details] Run launcher under jhbuild, v2 View in context: https://bugs.webkit.org/attachment.cgi?id=132282&action=review > Tools/Scripts/run-launcher:77 > + my $jhbuildWrapper = catdir(sourceDir(), "Tools", "efl", "run-with-jhbuild"); > + $launcherPath = $jhbuildWrapper; Maybe this can be one line? $launcherPath = catdir(sourceDir(), "Tools", "efl", "run-with-jhbuild");

Dominik Röttsches (drott)

Comment 4 2012-03-19 02:38:14 PDT

Created attachment 132561 [details] Run launcher under jhbuild, v3 In one line, changelog rebased.

WebKit Review Bot

Comment 5 2012-03-19 03:47:46 PDT

Comment on attachment 132561 [details] Run launcher under jhbuild, v3 Clearing flags on attachment: 132561 Committed r111172: <http://trac.webkit.org/changeset/111172>

WebKit Review Bot

Comment 6 2012-03-19 03:47:51 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.