Bug 79898

Summary: perf-o-matic should incrementally update JSON responses
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: WebKit WebsiteAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, morrita
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 80364    
Bug Blocks: 77037    
Attachments:
Description Flags
Patch
eric: review+
Second attempt eric: review+

Ryosuke Niwa
Reported 2012-02-29 02:04:17 PST
We're running out of quota on the app engine because of the front-end time. As far as I understand, we're spending ridiculous amount of time iterating through all test result objects to generate "runs" JSON responses. We should do this incrementally instead.
Attachments
Patch (18.00 KB, patch)
2012-02-29 02:11 PST, Ryosuke Niwa 		eric: review+
DetailsFormatted DiffDiff
Second attempt (12.88 KB, patch)
2012-03-08 01:28 PST, Ryosuke Niwa 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-02-29 02:11:49 PST
Created attachment 129421 [details] Patch
Ryosuke Niwa
Comment 2 2012-02-29 14:24:30 PST
Apparently, this isn't much of an issue after some investigation. The biggest cause of the huge frontend hours appears to be coming from the dashboard, which ends up loading a whole dozens of files in each of 132 iframes...
Eric Seidel (no email)
Comment 3 2012-03-01 13:51:38 PST
Comment on attachment 129421 [details] Patch OK.
Ryosuke Niwa
Comment 4 2012-03-05 12:23:17 PST
I just realized that this may cause the values in JSON to get progressively worse since I'm doing string > float > string conversion on each run :(
Ryosuke Niwa
Comment 5 2012-03-08 01:28:26 PST
Created attachment 130793 [details] Second attempt
Eric Seidel (no email)
Comment 6 2012-03-08 13:38:23 PST
Comment on attachment 130793 [details] Second attempt OK.
Ryosuke Niwa
Comment 7 2012-03-08 14:58:58 PST
Committed r110210: <http://trac.webkit.org/changeset/110210>
Note You need to log in before you can comment on or make changes to this bug.