Bug 79051

Summary: INPUT_SPEECH should be implemented as a PageSupplement.
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: PlatformAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 78440    
Attachments:
Description Flags
Patch
none
Patch for landing none

Hajime Morrita
Reported 2012-02-20 16:20:56 PST
This is series of supplement-ification (Bug 78440). SpeechIput and its client should be pushed out from Page class using PageSupplement.
Attachments
Patch (10.22 KB, patch)
2012-02-21 20:35 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.21 KB, patch)
2012-02-21 20:57 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2012-02-21 20:35:04 PST
Created attachment 128124 [details] Patch
Hajime Morrita
Comment 2 2012-02-21 20:36:35 PST
Hi Adam, could you take a look? I feel this is as simple as stamp-able.
Adam Barth
Comment 3 2012-02-21 20:50:01 PST
Comment on attachment 128124 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128124&action=review > Source/WebCore/page/SpeechInput.cpp:122 > + DEFINE_STATIC_LOCAL(AtomicString, name, ("speechInput")); speechInput => SpeechInput ?
Hajime Morrita
Comment 4 2012-02-21 20:57:39 PST
Created attachment 128125 [details] Patch for landing
Hajime Morrita
Comment 5 2012-02-21 20:58:22 PST
(In reply to comment #3) > (From update of attachment 128124 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=128124&action=review > > > Source/WebCore/page/SpeechInput.cpp:122 > > + DEFINE_STATIC_LOCAL(AtomicString, name, ("speechInput")); > > speechInput => SpeechInput ? Done. I'll fix other existing naming inconsistency later.
WebKit Review Bot
Comment 6 2012-02-21 21:45:54 PST
Comment on attachment 128125 [details] Patch for landing Clearing flags on attachment: 128125 Committed r108446: <http://trac.webkit.org/changeset/108446>
WebKit Review Bot
Comment 7 2012-02-21 21:46:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.