Bug 78817

Summary: [Qt] Print warning when importing experimental WK2 APIs in QML
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: WebKit APIAssignee: Andras Becsi <abecsi>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 74403    
Attachments:
Description Flags
proposed patch
none
proposed patch none

Simon Hausmann
Reported 2012-02-16 08:04:33 PST
Similar to qmake printing a warning when using private Qt C++ APIs, we should print a warning (using qWarning?) when an application imports the experimental QML WebKit2 APIs.
Attachments
proposed patch (1.46 KB, patch)
2012-02-20 11:30 PST, Andras Becsi 		no flags
DetailsFormatted DiffDiff
proposed patch (1.48 KB, patch)
2012-02-21 02:14 PST, Andras Becsi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andras Becsi
Comment 1 2012-02-20 11:30:32 PST
Created attachment 127838 [details] proposed patch
Kenneth Rohde Christiansen
Comment 2 2012-02-20 12:08:25 PST
Comment on attachment 127838 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=127838&action=review > Source/WebKit/qt/declarative/experimental/plugin.cpp:49 > + qWarning("\nWARNING: This project is using the experimental QML WebKit2 API and is therefore tied to a specific QtWebKit version.\n" it sounds as the whole API is experimental! This project is using the experimental QML API extensions for QtWebKit and it therefore tied to a specific QtWebKit release.
Andras Becsi
Comment 3 2012-02-21 02:14:55 PST
Created attachment 127946 [details] proposed patch
WebKit Review Bot
Comment 4 2012-02-21 03:34:07 PST
Comment on attachment 127946 [details] proposed patch Clearing flags on attachment: 127946 Committed r108333: <http://trac.webkit.org/changeset/108333>
WebKit Review Bot
Comment 5 2012-02-21 03:34:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.