Bug 78633

Summary: [BlackBerry] Upstreaming WebSettings code
Product: WebKit Reporter: Nima Ghanavatian <nima.ghanavatian>
Component: New BugsAssignee: Nima Ghanavatian <nima.ghanavatian>
Status: RESOLVED FIXED    
Severity: Normal CC: jkjiang, rwlbuis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73144    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Nima Ghanavatian
Reported 2012-02-14 14:36:06 PST
This includes WebSettings.cpp, WebSettings.h and WebSettings_p.h
Attachments
Patch (41.18 KB, patch)
2012-02-14 14:49 PST, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Patch (41.18 KB, patch)
2012-02-14 16:02 PST, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Patch (41.09 KB, patch)
2012-02-14 16:26 PST, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nima Ghanavatian
Comment 1 2012-02-14 14:49:59 PST
Created attachment 127049 [details] Patch
Jacky Jiang
Comment 2 2012-02-14 14:52:46 PST
(In reply to comment #1) > Created an attachment (id=127049) [details] > Patch I already created the bug https://bugs.webkit.org/show_bug.cgi?id=74379 before, you can mark either of this as dup if you'd like.
Rob Buis
Comment 3 2012-02-14 15:30:08 PST
Comment on attachment 127049 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127049&action=review > Source/WebKit/blackberry/Api/WebSettings.cpp:29 > +#include <wtf/Vector.h> Are all these needed? > Source/WebKit/blackberry/Api/WebSettings.cpp:590 > +// Whether to include pattern: in the list of string patterns period. > Source/WebKit/blackberry/Api/WebSettings.h:51 > + WebSettings(const WebSettings&); More common to put private section at the end. > Source/WebKit/blackberry/Api/WebSettings_p.h:25 > +#include <wtf/text/StringHash.h> Needed? > Source/WebKit/blackberry/Api/WebSettings_p.h:67 > + WTF::HashMap<WTF::String, PrimitiveValue> primitiveValues; You do not need WTF prefix on HashMap.
Nima Ghanavatian
Comment 4 2012-02-14 16:02:14 PST
Created attachment 127072 [details] Patch
Nima Ghanavatian
Comment 5 2012-02-14 16:26:06 PST
Created attachment 127074 [details] Patch
Rob Buis
Comment 6 2012-02-14 16:29:58 PST
Comment on attachment 127074 [details] Patch Looks good.
WebKit Review Bot
Comment 7 2012-02-14 17:48:11 PST
Comment on attachment 127074 [details] Patch Clearing flags on attachment: 127074 Committed r107764: <http://trac.webkit.org/changeset/107764>
WebKit Review Bot
Comment 8 2012-02-14 17:48:16 PST
All reviewed patches have been landed. Closing bug.
Jacky Jiang
Comment 9 2012-02-16 09:11:49 PST
*** Bug 74379 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.