Bug 78238
| Summary: | Style-checker doesn't complain about a style violation in a for statement without any initialization | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Julien Chaffraix <jchaffraix> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Julien Chaffraix
Seen on bug 78027, the following statement passed the style queue and should not have:
for (;child && child->isTableCol(); child = child->nextCol())
Note that the first semi-colon should have a space after per our guidelines.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Levin
If you care about this fix:
I'm happy to review changes to the style checker and they aren't that hard to do as several folks have demonstrated.
I'm also happy to give guidance on how to do these changes too!
(But in general, I don't have time to address these issues -- especially missed checks.)
PS I'm surprised that the style checker didn't catch this. I would guess that this is an easy fix :).