Bug 78082

Summary: [BlackBerry] Upstream InspectorClientBlackBerry.{h, cpp}
Product: WebKit Reporter: Leo Yang <leo.yang>
Component: New BugsAssignee: Leo Yang <leo.yang>
Status: RESOLVED FIXED    
Severity: Normal CC: charles.wei, rwlbuis, staikos, tonikitoo, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73144    
Attachments:
Description Flags
Patch
rwlbuis: review-
Patch v2 rwlbuis: review+

Leo Yang
Reported 2012-02-07 22:42:28 PST
This is the BlackBerry implement of InspectorClient.
Attachments
Patch (8.45 KB, patch)
2012-02-07 22:49 PST, Leo Yang 		rwlbuis: review-
DetailsFormatted DiffDiff
Patch v2 (8.44 KB, patch)
2012-02-08 18:55 PST, Leo Yang 		rwlbuis: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Leo Yang
Comment 1 2012-02-07 22:49:12 PST
Created attachment 126009 [details] Patch
Rob Buis
Comment 2 2012-02-08 04:39:36 PST
Comment on attachment 126009 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126009&action=review Looks good, can be cleaned up a bit more. > Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp:25 > +#include "FrameView.h" Do you need this include? > Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp:26 > +#include "IntRect.h" Ditto. > Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp:27 > +#include "IntSize.h" Ditto. > Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp:132 > + CString utf8Message = message.utf8(); CString utf8Message = message.utf8(); > Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.h:24 > +#include "IntRect.h" Do you need this include?
Leo Yang
Comment 3 2012-02-08 18:55:17 PST
Created attachment 126219 [details] Patch v2
Rob Buis
Comment 4 2012-02-08 19:00:04 PST
Comment on attachment 126219 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=126219&action=review Looks good! > Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.h:56 > + virtual void clearBrowserCookies(); Better add an empty line here.
Leo Yang
Comment 5 2012-02-08 19:04:29 PST
(In reply to comment #4) > (From update of attachment 126219 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=126219&action=review > > Looks good! > > > Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.h:56 > > + virtual void clearBrowserCookies(); > > Better add an empty line here. Thanks. I will add a blank line before landing.
Leo Yang
Comment 6 2012-02-08 19:21:47 PST
Committed r107169: <http://trac.webkit.org/changeset/107169>
Note You need to log in before you can comment on or make changes to this bug.