Bug 78007

Created attachment 125884 [details] Patch

Created attachment 125887 [details] Patch

Created attachment 125889 [details] Patch

(The patch includes new baselines because of subtle changes to gradient pixels between the time the original baselines were added and the current WebKit.)

Comment on attachment 125889 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125889&action=review Why is there blue for these: LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-se-expected.png LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png ? They don't look right > Source/WebKit/chromium/src/NonCompositedContentHost.cpp:49 > + m_graphicsLayer->platformLayer()->setBackgroundCoversViewport(false); just #ifdef out the call with (true), it's false by default

Comment on attachment 125889 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125889&action=review >> Source/WebKit/chromium/src/NonCompositedContentHost.cpp:49 >> + m_graphicsLayer->platformLayer()->setBackgroundCoversViewport(false); > > just #ifdef out the call with (true), it's false by default Done.

Created attachment 125910 [details] Patch

(In reply to comment #5) > (From update of attachment 125889 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=125889&action=review > > Why is there blue for these: > > LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png > LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png > LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-se-expected.png > LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png > > ? They don't look right The tests set: ::-webkit-scrollbar-track-piece, ::-webkit-scrollbar-corner { background-color: blue; }

(In reply to comment #8) > (In reply to comment #5) > > (From update of attachment 125889 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=125889&action=review > > > > Why is there blue for these: > > > > LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png > > LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png > > LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-se-expected.png > > LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png > > > > ? They don't look right > > The tests set: > > ::-webkit-scrollbar-track-piece, > ::-webkit-scrollbar-corner { > background-color: blue; > } Oh! My mistake, I was confusing that with the debug blue we use. Might be better if the tests used green or something for scrollbars. Anyway, this patch is fine, then. Thanks!

Comment on attachment 125910 [details] Patch Rejecting attachment 125910 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ositedContentHost.cpp patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #1 succeeded at 517 (offset -2 lines). Hunk #2 FAILED at 4050. 1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'James Robi..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11459133

Created attachment 126075 [details] Patch for landing

Comment on attachment 126075 [details] Patch for landing Rejecting attachment 126075 [details] from commit-queue. asvitkine@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.

Comment on attachment 126075 [details] Patch for landing Clearing flags on attachment: 126075 Committed r107094: <http://trac.webkit.org/changeset/107094>

All reviewed patches have been landed. Closing bug.

It looks like the baselines committed where were not matching the tests and I rebaselined them in http://trac.webkit.org/changeset/107109. Alexei, could you double check that the new ones make sense? Thanks!

Oops, sorry about that Julien. The rebaselines look good. Thanks!