Bug 77746

Summary: [CSSRegions]Implement NamedFlow::getRegionsByContentNode
Product: WebKit Reporter: Mihnea Ovidenie <mihnea>
Component: CSSAssignee: Mihnea Ovidenie <mihnea>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, ojan, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch 3
none
Patch 4
none
Patch for landing none

Mihnea Ovidenie
Reported 2012-02-03 09:35:24 PST
Spec: http://dev.w3.org/csswg/css3-regions/#the-namedflow-interface
Attachments
Patch (88.72 KB, patch)
2012-02-22 05:21 PST, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Patch for landing (90.80 KB, patch)
2012-02-26 23:29 PST, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Patch 3 (66.32 KB, patch)
2012-03-15 06:42 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Patch 4 (58.98 KB, patch)
2012-03-19 10:58 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Patch for landing (60.17 KB, patch)
2012-03-20 00:42 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Mihnea Ovidenie
Comment 1 2012-02-22 05:21:05 PST
Created attachment 128181 [details] Patch
Dave Hyatt
Comment 2 2012-02-22 13:18:31 PST
Comment on attachment 128181 [details] Patch r=me
WebKit Review Bot
Comment 3 2012-02-22 13:24:48 PST
Comment on attachment 128181 [details] Patch Rejecting attachment 128181 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: st.h patching file Source/WebCore/dom/WebKitNamedFlow.cpp patching file Source/WebCore/dom/WebKitNamedFlow.h patching file Source/WebCore/dom/WebKitNamedFlow.idl patching file Source/WebCore/rendering/RenderFlowThread.cpp patching file Source/WebCore/rendering/RenderFlowThread.h patching file Source/WebCore/rendering/RenderRegion.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'David Hyatt']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11569139
Mihnea Ovidenie
Comment 4 2012-02-26 23:29:03 PST
Created attachment 128964 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-02-27 01:19:30 PST
The commit-queue encountered the following flaky tests while processing attachment 128964 [details]: css3/filters/effect-invert-hw.html bug 79639 (author: cmarrin@apple.com) inspector/protocol/console-agent.html bug 79563 (authors: caseq@chromium.org, loislo@chromium.org, and pfeldman@chromium.org) The commit-queue is continuing to process your patch.
WebKit Review Bot
Comment 6 2012-02-27 01:22:09 PST
Comment on attachment 128964 [details] Patch for landing Clearing flags on attachment: 128964 Committed r108970: <http://trac.webkit.org/changeset/108970>
WebKit Review Bot
Comment 7 2012-02-27 01:22:14 PST
All reviewed patches have been landed. Closing bug.
Mihnea Ovidenie
Comment 8 2012-03-14 00:28:59 PDT
The current implementation, making the returned NodeList a live collection had some issues and was removed from trunk in https://bugs.webkit.org/show_bug.cgi?id=81021.
Mihnea Ovidenie
Comment 9 2012-03-15 06:42:00 PDT
Created attachment 132037 [details] Patch 3 Implement the list of regions as a static list.
Ryosuke Niwa
Comment 10 2012-03-18 23:59:40 PDT
Comment on attachment 132037 [details] Patch 3 View in context: https://bugs.webkit.org/attachment.cgi?id=132037&action=review The pathc looks reasonable but I need to either learn how RenderFlowThread works or let someone else review that. > LayoutTests/fast/regions/get-regions-by-content-node-expected.txt:10 > +PASS > +PASS > +PASS > +PASS > +PASS > +PASS These test results are impossible read. What did pass here? If you use js-test-pre.js, then you can use assertEqual, etc... to have more meaningful outputs here.
Mihnea Ovidenie
Comment 11 2012-03-19 10:58:05 PDT
Created attachment 132607 [details] Patch 4 Taking comments into account, simplify tests.
Dave Hyatt
Comment 12 2012-03-19 12:46:36 PDT
Comment on attachment 132607 [details] Patch 4 r=me
WebKit Review Bot
Comment 13 2012-03-19 13:19:55 PDT
Comment on attachment 132607 [details] Patch 4 Rejecting attachment 132607 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 126079 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 48>At revision 126079. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/11985561
Eric Seidel (no email)
Comment 14 2012-03-19 13:24:05 PDT
Lets try again. This may be a CQ bug.
WebKit Review Bot
Comment 15 2012-03-19 13:26:06 PDT
Comment on attachment 132607 [details] Patch 4 Rejecting attachment 132607 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ing file Source/WebCore/dom/WebKitNamedFlow.idl Hunk #1 FAILED at 32. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/dom/WebKitNamedFlow.idl.rej patching file Source/WebCore/rendering/RenderFlowThread.cpp patching file Source/WebCore/rendering/RenderFlowThread.h patching file Source/WebCore/rendering/RenderRegion.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'David Hyatt']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11984707
Mihnea Ovidenie
Comment 16 2012-03-20 00:42:23 PDT
Created attachment 132774 [details] Patch for landing
WebKit Review Bot
Comment 17 2012-03-20 03:08:45 PDT
Comment on attachment 132774 [details] Patch for landing Clearing flags on attachment: 132774 Committed r111376: <http://trac.webkit.org/changeset/111376>
WebKit Review Bot
Comment 18 2012-03-20 03:08:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.