Bug 77632

Summary: [Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior.
Product: WebKit Reporter: Jocelyn Turcotte <jturcotte>
Component: New BugsAssignee: Jocelyn Turcotte <jturcotte>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, cmarcelo, hausmann, jesus, kenneth, menard, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77111    
Attachments:
Description Flags
Patch
none
Code moving patch (will squash before commit)
none
Patch kenneth: review+

Jocelyn Turcotte
Reported 2012-02-02 05:34:35 PST
[Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior.
Attachments
Patch (56.33 KB, patch)
2012-02-02 05:44 PST, Jocelyn Turcotte 		no flags
DetailsFormatted DiffDiff
Code moving patch (will squash before commit) (13.21 KB, patch)
2012-02-02 05:51 PST, Jocelyn Turcotte 		no flags
DetailsFormatted DiffDiff
Patch (56.95 KB, patch)
2012-02-02 08:00 PST, Jocelyn Turcotte 		kenneth: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2012-02-02 05:44:58 PST
Created attachment 125127 [details] Patch
Jocelyn Turcotte
Comment 2 2012-02-02 05:51:39 PST
Created attachment 125128 [details] Code moving patch (will squash before commit)
Kenneth Rohde Christiansen
Comment 3 2012-02-02 05:52:28 PST
Comment on attachment 125127 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125127&action=review > Source/WebKit2/ChangeLog:11 > + Reviewed by NOBODY (OOPS!). > + > + Replace the runtime property setting the desktop behavior on each instance by a static boolean > + controlling the behavior used by WebView created in the future. > + > + * UIProcess/API/qt/qquickwebpage.cpp: a bit shorter lines and some added newlines could make this changelog readable > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:58 > +static bool sUseTraditionalDesktopBehaviour = false; I believe s_ is what is commonly used > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:60 > +static QQuickWebViewPrivate* createPrivateObject(QQuickWebView* pub) pub? > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:65 > + if (sUseTraditionalDesktopBehaviour) > + return new QQuickWebViewDesktopPrivate(pub); > + return new QQuickWebViewTouchPrivate(pub); > +} im not convinced that Touch is the best way to describe the difference between the classes > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:684 > +void QQuickWebViewExperimental::setUseTraditionalDesktopBehaviour(bool enable) > +{ > + sUseTraditionalDesktopBehaviour = enable; > +} > + > +bool QQuickWebViewExperimental::useTraditionalDesktopBehaviour() > +{ > + return sUseTraditionalDesktopBehaviour; > +} > + So this cannot be changed at runtime?
Kenneth Rohde Christiansen
Comment 4 2012-02-02 06:56:14 PST
Comment on attachment 125127 [details] Patch Following ric discussions
Kenneth Rohde Christiansen
Comment 5 2012-02-02 06:56:25 PST
(In reply to comment #4) > (From update of attachment 125127 [details]) > Following ric discussions IRC that is
Jocelyn Turcotte
Comment 6 2012-02-02 08:00:25 PST
Created attachment 125133 [details] Patch
Kenneth Rohde Christiansen
Comment 7 2012-02-02 11:18:48 PST
Comment on attachment 125133 [details] Patch rs=me
Jocelyn Turcotte
Comment 8 2012-02-03 06:49:56 PST
Committed r106658: <http://trac.webkit.org/changeset/106658>
Note You need to log in before you can comment on or make changes to this bug.