Bug 77584

Summary: Refactoring: Share test drivers of shadow content tests.
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dominicc, hayato, morrita, rolandsteiner, shinyak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 76261, 76262    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Shinya Kawanaka
Reported 2012-02-01 17:12:36 PST
Currently we're using almost same test drivers in several shadow content tests. Definitely we can share the code.
Attachments
Patch (14.02 KB, patch)
2012-02-02 00:12 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (14.06 KB, patch)
2012-02-02 16:55 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-02-02 00:12:12 PST
Created attachment 125087 [details] Patch
Hajime Morrita
Comment 2 2012-02-02 01:21:17 PST
Comment on attachment 125087 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125087&action=review > LayoutTests/ChangeLog:13 > + * fast/dom/shadow/shadow-test-driver.js: Added. Could you move this under dom/resources/ ? That marks the file is not a test.
Shinya Kawanaka
Comment 3 2012-02-02 16:55:53 PST
Created attachment 125211 [details] Patch
Hajime Morrita
Comment 4 2012-02-02 17:52:25 PST
Comment on attachment 125211 [details] Patch Nice!
WebKit Review Bot
Comment 5 2012-02-02 19:33:26 PST
Comment on attachment 125211 [details] Patch Clearing flags on attachment: 125211 Committed r106619: <http://trac.webkit.org/changeset/106619>
WebKit Review Bot
Comment 6 2012-02-02 19:33:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.