Bug 77436

Summary: [Chromium] Minimum Scale Factor computed based on stale visibleContentsRect
Product: WebKit Reporter: Fady Samuel <fsamuel>
Component: New BugsAssignee: Fady Samuel <fsamuel>
Status: RESOLVED WONTFIX    
Severity: Normal CC: aelias, fishd, jamesr, rjkroege, schenney, siraj, tdanderson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 70559    
Attachments:
Description Flags
Patch jamesr: review-

Fady Samuel
Reported 2012-01-31 07:22:32 PST
[Chromium] Minimum Scale Factor computed based on stale visibleContentsRect
Attachments
Patch (3.50 KB, patch)
2012-01-31 07:24 PST, Fady Samuel 		jamesr: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fady Samuel
Comment 1 2012-01-31 07:24:19 PST
Created attachment 124728 [details] Patch
WebKit Review Bot
Comment 2 2012-01-31 07:26:07 PST
Attachment 124728 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource First, rewinding head to replay your work on top of it... Applying: Fix compilation errors on build-webkit --debug --no-workers on mac. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Auto-merging LayoutTests/platform/qt/Skipped CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped Auto-merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Fisher (:fishd, Google)
Comment 3 2012-01-31 13:04:39 PST
Comment on attachment 124728 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124728&action=review > Source/WebCore/page/FrameView.cpp:2961 > + if (!m_frame->document()) what's the relationship between this change and the change to ChromeClientImpl.cpp?
James Robinson
Comment 4 2012-02-21 20:56:18 PST
Comment on attachment 124728 [details] Patch Where is your test?
Note You need to log in before you can comment on or make changes to this bug.