Bug 77322

Summary: No need to keep anonymous RenderBlock in DETAILS
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 76262    
Attachments:
Description Flags
Patch none

Shinya Kawanaka
Reported 2012-01-30 01:25:05 PST
When detaching children of DETAILS element, anonymous RenderBlock may be left. It was introduced to prevent crash in r81812, but actually it is not necessary now. It often keeps unnecessary anonymous RenderObjects, and causes unexpected text diff mismatch when tweaking content element.
Attachments
Patch (1.76 KB, patch)
2012-01-30 01:42 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-01-30 01:42:35 PST
Created attachment 124509 [details] Patch
Shinya Kawanaka
Comment 2 2012-01-30 01:45:04 PST
With this patch, Bug 76262's patch will not fail the following tests. fast/html/details-replace-text.html fast/html/details-remove-child-1.html And you can see that this test's expectation has unnecessary RenderBlock (so unexpected text mismatch will occur). fast/html/details-remove-child-2.html I will fix them in Bug 76262.
Hajime Morrita
Comment 3 2012-01-30 02:08:58 PST
Comment on attachment 124509 [details] Patch Good catch! Evil is between the lines...
WebKit Review Bot
Comment 4 2012-01-30 03:32:36 PST
Comment on attachment 124509 [details] Patch Clearing flags on attachment: 124509 Committed r106228: <http://trac.webkit.org/changeset/106228>
WebKit Review Bot
Comment 5 2012-01-30 03:32:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.