Bug 77150

Summary: [JSC] Asm-originated symbols should be marked as hidden
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: JavaScriptCoreAssignee: Simon Hausmann <hausmann>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, hausmann, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 72854    
Attachments:
Description Flags
Patch none

Hajime Morrita
Reported 2012-01-26 15:06:50 PST
This is from Bug 72854. Following symbols are currently not marked as hidden, that means these will be visible if we switched off the exp list based symbol management. We need to mark them hidden. ---- __ZThn16_N3JSC9CodeBlockD0Ev __ZThn16_N3JSC9CodeBlockD1Ev _ceilThunk _expThunk _floorThunk _jsRoundThunk _logThunk _getHostCallReturnValue _operationGetByIdBuildList _operationGetByIdOptimize _operationGetByIdProtoBuildList _operationLinkCall _operationLinkConstruct _operationPutByIdDirectNonStrictOptimize _operationPutByIdDirectStrictOptimize _operationPutByIdNonStrictOptimize _operationPutByIdStrictOptimize ----
Attachments
Patch (2.35 KB, patch)
2012-01-27 03:51 PST, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2012-01-27 03:51:36 PST
Created attachment 124285 [details] Patch
Hajime Morrita
Comment 2 2012-01-27 09:01:29 PST
CC-ing Filip, an expert in this area.
Filip Pizlo
Comment 3 2012-01-27 13:30:47 PST
Comment on attachment 124285 [details] Patch I take it there will be additional packages to hide the various other symbols? R=me.
Hajime Morrita
Comment 4 2012-01-27 13:48:05 PST
(In reply to comment #3) > (From update of attachment 124285 [details]) > I take it there will be additional packages to hide the various other symbols? R=me. Yeah, this is a part of effort to kill JavaScriptCore.exp with function-based annotation JS_EXPORT_PRIVATE. Thanks for your quick take, Filip.
Filip Pizlo
Comment 5 2012-01-27 13:48:40 PST
(In reply to comment #3) > (From update of attachment 124285 [details]) > I take it there will be additional packages to hide the various other symbols? R=me. Ooops, sorry I meant to say "patches" not "packages".
WebKit Review Bot
Comment 6 2012-01-27 14:43:49 PST
Comment on attachment 124285 [details] Patch Clearing flags on attachment: 124285 Committed r106153: <http://trac.webkit.org/changeset/106153>
WebKit Review Bot
Comment 7 2012-01-27 14:43:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.