Bug 76947

Summary: "text" and "URL" legacy clipboard types should not be case sensitive
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dcheng, dglazkov, dpranke, enrica, ojan, oliver, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 76198    
Attachments:
Description Flags
Patch
none
Patch for landing none

Attachments
Patch (8.39 KB, patch)
2012-01-24 14:45 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.10 KB, patch)
2012-01-25 16:02 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2012-01-24 14:40:21 PST
I believe Oliver worked on ClipboardMac most recently, so he might want to see this go by.
Eric Seidel (no email)
Comment 2 2012-01-24 14:41:21 PST
Looks like Enrica was actually the last person in the file, so I'll CC her too: http://trac.webkit.org/log/trunk/Source/WebCore/platform/mac/ClipboardMac.mm
Eric Seidel (no email)
Comment 3 2012-01-24 14:45:09 PST
Created attachment 123814 [details] Patch
Adam Barth
Comment 4 2012-01-24 16:09:15 PST
Comment on attachment 123814 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123814&action=review > Source/WebCore/platform/mac/ClipboardMac.mm:72 > + String qType = type.lower(); Why not equalsIgnoringCase ?
Eric Seidel (no email)
Comment 5 2012-01-24 16:12:59 PST
(In reply to comment #4) > (From update of attachment 123814 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=123814&action=review > > > Source/WebCore/platform/mac/ClipboardMac.mm:72 > > + String qType = type.lower(); > > Why not equalsIgnoringCase ? That woudl be find too was attempting to be litteral with the spec. :)
Daniel Cheng
Comment 6 2012-01-24 16:16:44 PST
(In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 123814 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=123814&action=review > > > > > Source/WebCore/platform/mac/ClipboardMac.mm:72 > > > + String qType = type.lower(); > > > > Why not equalsIgnoringCase ? > > That woudl be find too was attempting to be litteral with the spec. :) There are places that do things like Clipboard::types().contains(x). Is there an equivalent of equalsIgnoringCase for HashSet<String>? Otherwise I wonder if we're better off just lower-casing anyway.
Adam Barth
Comment 7 2012-01-24 16:18:01 PST
I think there's a CaseFoldingHash, but lowercasing is probably just fine here.
WebKit Review Bot
Comment 8 2012-01-24 16:23:09 PST
Comment on attachment 123814 [details] Patch Attachment 123814 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11294108 New failing tests: editing/pasteboard/dataTransfer-setData-getData.html
Eric Seidel (no email)
Comment 9 2012-01-25 15:51:37 PST
OMG. This is because the Chromium port falls back to "mac" for results. Someone shoot me now.
Eric Seidel (no email)
Comment 10 2012-01-25 15:53:45 PST
I've filed https://bugs.webkit.org/show_bug.cgi?id=77054 about fixing the chromium fallback insanity.
Eric Seidel (no email)
Comment 11 2012-01-25 16:02:38 PST
Created attachment 124029 [details] Patch for landing
WebKit Review Bot
Comment 12 2012-01-25 16:27:21 PST
Comment on attachment 124029 [details] Patch for landing Clearing flags on attachment: 124029 Committed r105941: <http://trac.webkit.org/changeset/105941>
WebKit Review Bot
Comment 13 2012-01-25 16:27:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.