Bug 76864

Summary: Implement flex-pack:distribute
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: eoconnor, macpherson, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 62048    
Attachments:
Description Flags
Patch
none
Patch none

Ojan Vafai
Reported 2012-01-23 14:43:27 PST
Implement flex-pack:distribute
Attachments
Patch (9.97 KB, patch)
2012-01-23 14:45 PST, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Patch (10.14 KB, patch)
2012-01-23 15:35 PST, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-01-23 14:45:19 PST
Created attachment 123626 [details] Patch
Tony Chang
Comment 2 2012-01-23 15:26:40 PST
Comment on attachment 123626 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123626&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) You'll need to fix this. It would also be nice to provide a link to the spec. > Source/WebCore/rendering/RenderFlexibleBox.cpp:584 > + if (flexPack == PackDistribute) > + return availableFreeSpace / (2 * numberOfChildren); What happens if we have 0 children? Can we add a test case for that?
Ojan Vafai
Comment 3 2012-01-23 15:35:31 PST
Created attachment 123637 [details] Patch
WebKit Review Bot
Comment 4 2012-01-23 22:27:13 PST
Comment on attachment 123637 [details] Patch Clearing flags on attachment: 123637 Committed r105694: <http://trac.webkit.org/changeset/105694>
WebKit Review Bot
Comment 5 2012-01-23 22:27:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.