Bug 76366

Summary: [Blackberry] Non-supported about: operations never stops loading
Product: WebKit Reporter: Chris.Guan <logingx>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: logingx, rwlbuis, staikos, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73144    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris.Guan
Reported 2012-01-15 22:27:45 PST
If user typed the non-supported "about:" scheme such as "about:nonsupport", we should take it as an error of invalid url.
Attachments
Patch (5.34 KB, patch)
2012-02-05 20:03 PST, Chris.Guan 		no flags
DetailsFormatted DiffDiff
Patch (13.27 KB, patch)
2012-02-05 20:09 PST, Chris.Guan 		no flags
DetailsFormatted DiffDiff
Patch (5.33 KB, patch)
2012-02-05 21:19 PST, Chris.Guan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris.Guan
Comment 1 2012-02-05 20:03:01 PST
Created attachment 125554 [details] Patch
Chris.Guan
Comment 2 2012-02-05 20:09:14 PST
Created attachment 125556 [details] Patch
Antonio Gomes
Comment 3 2012-02-05 20:33:03 PST
Comment on attachment 125556 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125556&action=review you amended wrongly :-) > Source/WebCore/ChangeLog:8 > + If user typed the non-supported "about:" scheme such as "about:nonsupport", nit: s/the/a > Source/WebCore/ChangeLog:9 > + loadAboutURL() fucntion in NetworkManger should recognize and handle typo: function* > Source/WebCore/ChangeLog:33 > +2012-02-05 Andreas Kling <awesomekling@apple.com> > + > + Remove unused file MappedAttributeEntry.h. > + <http://webkit.org/b/77841> > + > + Reviewed by Anders Carlsson. > + > + * GNUmakefile.list.am: > + * WebCore.gypi: > + * WebCore.vcproj/WebCore.vcproj: > + * WebCore.xcodeproj/project.pbxproj: > + * dom/MappedAttributeEntry.h: Removed. > + * dom/StyledElement.h: > + this should not be here :-)
Chris.Guan
Comment 4 2012-02-05 21:19:32 PST
Created attachment 125562 [details] Patch
Antonio Gomes
Comment 5 2012-02-05 21:23:24 PST
Comment on attachment 125562 [details] Patch It looks ok to me... maybe our DRT support testing this, Rob?
Chris.Guan
Comment 6 2012-02-05 21:47:51 PST
(In reply to comment #5) > (From update of attachment 125562 [details]) > It looks ok to me... > > maybe our DRT support testing this, Rob? Thanks, Antonio, do you want DRT to run all schemata such as "data: about: credits: cache: config: ..."?
Antonio Gomes
Comment 7 2012-02-06 05:23:45 PST
(In reply to comment #6) > (In reply to comment #5) > > (From update of attachment 125562 [details] [details]) > > It looks ok to me... > > > > maybe our DRT support testing this, Rob? > > Thanks, Antonio, do you want DRT to run all schemata such as "data: about: credits: cache: config: ..."? hum, not sure. I would actually like to ensure that any other schemas other than the supported ones load as expected: error page :)
Chris.Guan
Comment 8 2012-02-06 05:47:48 PST
(In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > (From update of attachment 125562 [details] [details] [details]) > > > It looks ok to me... > > > > > > maybe our DRT support testing this, Rob? > > > > Thanks, Antonio, do you want DRT to run all schemata such as "data: about: credits: cache: config: ..."? > > hum, not sure. I would actually like to ensure that any other schemas other than the supported ones load as expected: error page :) yes, an invalide url err page will be shown up if that schema is not supported by us:)
Rob Buis
Comment 9 2012-02-06 06:55:31 PST
(In reply to comment #5) > (From update of attachment 125562 [details]) > It looks ok to me... > > maybe our DRT support testing this, Rob? The code looks fine to me too. I'll check whether DRT supports about: Cheers, Rob.
Chris.Guan
Comment 10 2012-02-06 06:57:48 PST
(In reply to comment #9) > (In reply to comment #5) > > (From update of attachment 125562 [details] [details]) > > It looks ok to me... > > > > maybe our DRT support testing this, Rob? > > The code looks fine to me too. I'll check whether DRT supports about: > Cheers, > > Rob. Thanks, Rob:)
Rob Buis
Comment 11 2012-02-06 07:16:27 PST
Comment on attachment 125562 [details] Patch The code looks fine. Can you make a unit test for this, since DRT is not suitable here?
WebKit Review Bot
Comment 12 2012-02-06 08:39:40 PST
Comment on attachment 125562 [details] Patch Clearing flags on attachment: 125562 Committed r106810: <http://trac.webkit.org/changeset/106810>
WebKit Review Bot
Comment 13 2012-02-06 08:39:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.