Bug 76266

Summary: Cache RenderStyle pointer in updateBoxModelInfoFromStyle methods
Product: WebKit Reporter: Mihnea Ovidenie <mihnea>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 76265    
Attachments:
Description Flags
Patch kling: review-

Mihnea Ovidenie
Reported 2012-01-13 04:36:45 PST
Modify RenderBoxModelObject/RenderBox::updateBoxModelInfoFromStyle to cache the result of RenderObject::style() and use that result instead of repeatedly calling the style() method.
Attachments
Patch (3.70 KB, patch)
2012-01-13 04:42 PST, Mihnea Ovidenie 		kling: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mihnea Ovidenie
Comment 1 2012-01-13 04:42:50 PST
Created attachment 122410 [details] Patch
Andreas Kling
Comment 2 2012-01-13 05:34:49 PST
Comment on attachment 122410 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122410&action=review > Source/WebCore/ChangeLog:8 > + Refactoring code therefore no new tests. (OOPS!) CQ can't land this automatically with the OOPS intact, you need to remove it. Also, you should mention why we are doing this, as it's not obvious since RenderObject::style() is just a trivial inline getter right now.
Note You need to log in before you can comment on or make changes to this bug.