Bug 76226

Summary: table border spacing test for CSS3 calc
Product: WebKit Reporter: Mike Lawther <mikelawther>
Component: New BugsAssignee: Mike Lawther <mikelawther>
Status: RESOLVED FIXED    
Severity: Normal CC: jchaffraix, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 16662    
Attachments:
Description Flags
Patch
none
Patch for landing none

Mike Lawther
Reported 2012-01-12 16:53:57 PST
table border spacing test for CSS3 calc
Attachments
Patch (3.18 KB, patch)
2012-01-12 16:55 PST, Mike Lawther 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.13 KB, patch)
2012-01-24 22:28 PST, Mike Lawther 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike Lawther
Comment 1 2012-01-12 16:55:51 PST
Created attachment 122339 [details] Patch
Julien Chaffraix
Comment 2 2012-01-24 15:09:36 PST
Comment on attachment 122339 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122339&action=review > LayoutTests/css3/calc/table-border-spacing.html:5 > + vertical-align: top; Nit: This line is not be needed for the test. > LayoutTests/css3/calc/table-border-spacing.html:15 > + position: relative Ditto.
Mike Lawther
Comment 3 2012-01-24 22:27:45 PST
Comment on attachment 122339 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122339&action=review Thanks for the review Julien! >> LayoutTests/css3/calc/table-border-spacing.html:5 >> + vertical-align: top; > > Nit: This line is not be needed for the test. Done. >> LayoutTests/css3/calc/table-border-spacing.html:15 >> + position: relative > > Ditto. Done.
Mike Lawther
Comment 4 2012-01-24 22:28:20 PST
Created attachment 123884 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-01-25 04:39:18 PST
Comment on attachment 123884 [details] Patch for landing Clearing flags on attachment: 123884 Committed r105869: <http://trac.webkit.org/changeset/105869>
WebKit Review Bot
Comment 6 2012-01-25 04:39:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.