Bug 76122

Summary: [CMAKE][WK2] Cleanup WebKit2/CMakeLists.txt.
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit2Assignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: paroga, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61838    
Attachments:
Description Flags
Patch eric: review+, webkit.review.bot: commit-queue-

Ryuan Choi
Reported 2012-01-11 16:35:21 PST
WebKit2/CMakeLists.txt is not maintained well for a long time. This bug catch up the changes.
Attachments
Patch (9.30 KB, patch)
2012-01-11 19:18 PST, Ryuan Choi 		eric: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2012-01-11 19:18:55 PST
Created attachment 122157 [details] Patch
Eric Seidel (no email)
Comment 2 2012-02-16 13:22:49 PST
Comment on attachment 122157 [details] Patch OK.
WebKit Review Bot
Comment 3 2012-02-16 13:29:26 PST
Comment on attachment 122157 [details] Patch Rejecting attachment 122157 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: 2 lines). Hunk #8 succeeded at 349 (offset 2 lines). Hunk #9 succeeded at 387 (offset 2 lines). Hunk #10 succeeded at 402 (offset 1 line). Hunk #11 FAILED at 464. Hunk #12 succeeded at 479 (offset 1 line). Hunk #13 succeeded at 491 (offset 1 line). 3 out of 13 hunks FAILED -- saving rejects to file Source/WebKit2/CMakeLists.txt.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11539217
Patrick R. Gansterer
Comment 4 2012-02-23 01:32:24 PST
Most of the changes are already in r108227: <http://trac.webkit.org/changeset/108227>
Patrick R. Gansterer
Comment 5 2012-02-23 01:32:42 PST
Committed r108622: <http://trac.webkit.org/changeset/108622>
Note You need to log in before you can comment on or make changes to this bug.