Bug 75830

Summary: [Refactoring] Use join(", ", @arguments) to build a method argument string in CodeGeneratorJS.pm
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 72138    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-01-09 00:06:40 PST
This is a refactoring for implementing the [Supplemental] IDL for methods (bug 72138). The code in CodeGeneratorJS.pm to build a method argument string is dirty and error-prone. It is concatenating arguments one by one judging whether ", " is necessary or not. Instead, we should refactor the code so that it pushes all arguments into @arguments and then build a method string by join(", ", @arguments).
Attachments
Patch (6.43 KB, patch)
2012-01-09 00:10 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-01-09 00:10:28 PST
Created attachment 121626 [details] Patch
WebKit Review Bot
Comment 2 2012-01-09 01:38:54 PST
Comment on attachment 121626 [details] Patch Clearing flags on attachment: 121626 Committed r104443: <http://trac.webkit.org/changeset/104443>
WebKit Review Bot
Comment 3 2012-01-09 01:38:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.