Bug 7578

Summary: TinyMCE: Implement execCommand CreateLink
Product: WebKit Reporter: Justin Garcia <justin.garcia>
Component: HTML EditingAssignee: Justin Garcia <justin.garcia>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 6627    
Attachments:
Description Flags
patch mjs: review+

Justin Garcia
Reported 2006-03-03 14:55:14 PST
Implement execCommand link and unlink
Attachments
patch (34.61 KB, patch)
2006-03-14 16:09 PST, Justin Garcia 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Justin Garcia
Comment 1 2006-03-09 12:04:07 PST
I'm going to split UnLink off into it's own bug
Justin Garcia
Comment 2 2006-03-14 16:09:47 PST
Created attachment 7066 [details] patch Another way to do this would be to pull out the parts of ApplyStyleCommand that apply style to text runs from the parts that do the setup, traversal and cleanup, and make two new classes, PushInlineChangeCommand and ApplyInlineStyleCommand, with CreateLink and ApplyinlineStyleCommand as subclasses of PushInlineChangeCommand. That's more risky and probably not worth the effort unless we think we'll end up needing PushInlineChange in order to implement something else.
Maciej Stachowiak
Comment 3 2006-03-14 21:27:20 PST
Comment on attachment 7066 [details] patch Slighly odd way to do it. r=me
Note You need to log in before you can comment on or make changes to this bug.