Bug 75518

Summary: [GTK] [AC] Simplify accelerated compositing build options
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, gustavo, joone.hur, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 74087    
Attachments:
Description Flags
Patch
none
Patch none

Martin Robinson
Reported 2012-01-03 20:59:33 PST
We can eliminate the --enable-3d-rendering option, as right now it aligns exactly with accelerated compositing support. This will also prevent enabling accelerated compositing, but not 3D rendering.
Attachments
Patch (5.76 KB, patch)
2012-01-03 21:14 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (6.24 KB, patch)
2012-01-06 18:23 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2012-01-03 21:14:13 PST
Created attachment 121054 [details] Patch
Alejandro G. Castro
Comment 2 2012-01-05 04:44:51 PST
Comment on attachment 121054 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121054&action=review LGTM, just a clarification. > Source/WebCore/GNUmakefile.am:556 > + -DUSE_ACCELERATED_COMPOSITING=1 Shouldn't we use WTF_USE_ ? The cppflags were already defined in the GNUMakefile.am of the base directory, should we remove them there?
Martin Robinson
Comment 3 2012-01-06 18:23:13 PST
Created attachment 121530 [details] Patch
Martin Robinson
Comment 4 2012-01-06 18:24:06 PST
(In reply to comment #3) > Created an attachment (id=121530) [details] > Patch Thanks for the review! Both issues you pointed out were important problems with my first patch. I have tried to correct them in the latest version.
Gustavo Noronha (kov)
Comment 5 2012-01-09 04:37:38 PST
Comment on attachment 121530 [details] Patch +1 =)
WebKit Review Bot
Comment 6 2012-01-09 07:08:58 PST
Comment on attachment 121530 [details] Patch Clearing flags on attachment: 121530 Committed r104459: <http://trac.webkit.org/changeset/104459>
WebKit Review Bot
Comment 7 2012-01-09 07:09:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.