Bug 75330

Summary: REGRESSION (r92823): Background color not preserved when copying and pasting a table row
Product: WebKit Reporter: mitz
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, enrica, ossy, rniwa, tony, webkit-bug-importer
Priority: P1 Keywords: HasReduction, InRadar, Regression
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 75615    
Attachments:
Description Flags
Email message for reproducing the bug
none
reduction
none
fixes the bug tony: review+

mitz
Reported 2011-12-28 16:41:54 PST
Created attachment 120708 [details] Email message for reproducing the bug Steps to reproduce: 0. In Mail preferences > Compositing, select “Include selected text, if any; otherwise include all text” 1. Open the attached patch.eml in Mail 2. Tripe-click the green line to select it in its entirety 3. Choose Message > Reply Expected results: In the new compose window, the quoted row maintains its green background color. Actual result: In the new compose window, the quoted row is missing the green background color. Regression: Caused by <http://trac.webkit.org/r92823> Notes: Alternatively, you can reproduce this by opening the message in Mail, choosing Message > Send again, selecting the row, cutting it, and pasting it, or even copying and pasting in-place.
Attachments
Email message for reproducing the bug (2.47 KB, text/plain)
2011-12-28 16:41 PST, mitz 		no flags
Details
reduction (600 bytes, text/html)
2012-01-03 16:55 PST, Ryosuke Niwa 		no flags
Details
fixes the bug (7.05 KB, patch)
2012-01-03 17:51 PST, Ryosuke Niwa 		tony: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2011-12-28 16:42:25 PST
<rdar://problem/10630181>
Ryosuke Niwa
Comment 2 2012-01-03 16:55:42 PST
Created attachment 121020 [details] reduction Reproduction steps: 1. Open the attached file 2. Copy 3. Paste inside iframe
Ryosuke Niwa
Comment 3 2012-01-03 17:51:45 PST
Created attachment 121029 [details] fixes the bug
Tony Chang
Comment 4 2012-01-04 09:52:27 PST
Comment on attachment 121029 [details] fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=121029&action=review > Source/WebCore/editing/EditingStyle.cpp:99 > +static PassRefPtr<CSSMutableStyleDeclaration> editingStyleFromComputedStyle(PassRefPtr<CSSComputedStyleDeclaration> style, bool includeNonInheritableProperties = false) Nit: Should we convert includeNonInheritableProperties to an enum? > LayoutTests/editing/pasteboard/copy-element-with-conflicting-background-color-from-rule.html:5 > +The pated text should have lightgreen background color.</p> pated -> pasted
Ryosuke Niwa
Comment 5 2012-01-04 14:05:26 PST
Committed r104068: <http://trac.webkit.org/changeset/104068>
Csaba Osztrogonác
Comment 6 2012-01-04 14:28:09 PST
(In reply to comment #5) > Committed r104068: <http://trac.webkit.org/changeset/104068> It broke 12 tests on GTK and on Qt: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r104068%20(15677)/results.html
Ryosuke Niwa
Comment 7 2012-01-04 14:36:44 PST
(In reply to comment #6) > (In reply to comment #5) > > Committed r104068: <http://trac.webkit.org/changeset/104068> > > It broke 12 tests on GTK and on Qt: > http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r104068%20(15677)/results.html I'm confused. Qt bot hasn't even caught up yet. Also, my patch can't affect non-editing tests as EditingStyle isn't used anywhere but in editing.
Csaba Osztrogonác
Comment 8 2012-01-04 14:46:18 PST
(In reply to comment #7) > I'm confused. Qt bot hasn't even caught up yet. Also, my patch can't affect non-editing tests as EditingStyle isn't used anywhere but in editing. Our internal bots caught your patch: http://build.webkit.sed.hu/waterfall?category=core
Ryosuke Niwa
Comment 9 2012-01-04 14:50:25 PST
(In reply to comment #8) > (In reply to comment #7) > > I'm confused. Qt bot hasn't even caught up yet. Also, my patch can't affect non-editing tests as EditingStyle isn't used anywhere but in editing. > > Our internal bots caught your patch: http://build.webkit.sed.hu/waterfall?category=core Oops, that's because I have a busted Element.cpp change :( Didn't see that. Will revert it in a minute.
Ryosuke Niwa
Comment 10 2012-01-04 15:04:18 PST
(In reply to comment #9) > Oops, that's because I have a busted Element.cpp change :( Didn't see that. Will revert it in a minute. Reverted it in http://trac.webkit.org/changeset/104081.
Ryosuke Niwa
Comment 11 2012-04-23 00:01:55 PDT
Fixed in http://trac.webkit.org/changeset/104068.
Note You need to log in before you can comment on or make changes to this bug.