Bug 74657

Summary: [Chromium] Re-enable all layout tests for dedicated workers
Product: WebKit Reporter: Dmitry Lomov <dslomov>
Component: Tools / TestsAssignee: Dmitry Lomov <dslomov>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dslomov, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66511    
Attachments:
Description Flags
Tests reenabled
levin: review+, levin: commit-queue-
ChangeLog fixed
dslomov: commit-queue-
Invalid renames fixed!!!
none
Now fixed fo realz.
webkit.review.bot: commit-queue-
requestFileSystem vs. webkitRequestFileSystem for workers
levin: review+, webkit.review.bot: commit-queue-
ChangeLog fixed none

Dmitry Lomov
Reported 2011-12-15 15:50:34 PST
Follow-up for https://bugs.webkit.org/show_bug.cgi?id=74456. Re-enabling remaining tests.
Attachments
Tests reenabled (18.98 KB, patch)
2011-12-15 17:01 PST, Dmitry Lomov 		levin: review+
levin: commit-queue-
DetailsFormatted DiffDiff
ChangeLog fixed (18.96 KB, patch)
2011-12-15 18:08 PST, Dmitry Lomov 		dslomov: commit-queue-
DetailsFormatted DiffDiff
Invalid renames fixed!!! (18.96 KB, patch)
2011-12-15 18:19 PST, Dmitry Lomov 		no flags
DetailsFormatted DiffDiff
Now fixed fo realz. (19.00 KB, patch)
2011-12-15 18:20 PST, Dmitry Lomov 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
requestFileSystem vs. webkitRequestFileSystem for workers (19.59 KB, patch)
2011-12-16 10:08 PST, Dmitry Lomov 		levin: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
ChangeLog fixed (19.59 KB, patch)
2011-12-16 11:41 PST, Dmitry Lomov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Dmitry Lomov
Comment 1 2011-12-15 17:01:32 PST
Created attachment 119522 [details] Tests reenabled
David Levin
Comment 2 2011-12-15 18:04:42 PST
Comment on attachment 119522 [details] Tests reenabled View in context: https://bugs.webkit.org/attachment.cgi?id=119522&action=review Excellent! > LayoutTests/ChangeLog:11 > + * platform/chromium/http/tests/filesystem/workers/resolve-url-sync-expected.txt: webkitRequestFileSystem is not available in chromium DRT. fix comment.
Dmitry Lomov
Comment 3 2011-12-15 18:08:47 PST
Created attachment 119532 [details] ChangeLog fixed
Dmitry Lomov
Comment 4 2011-12-15 18:19:34 PST
Created attachment 119535 [details] Invalid renames fixed!!!
Dmitry Lomov
Comment 5 2011-12-15 18:20:56 PST
Created attachment 119536 [details] Now fixed fo realz.
WebKit Review Bot
Comment 6 2011-12-15 23:32:26 PST
Comment on attachment 119536 [details] Now fixed fo realz. Attachment 119536 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10900578 New failing tests: http/tests/inspector-enabled/dedicated-workers-list.html http/tests/filesystem/workers/resolve-url.html
Dmitry Lomov
Comment 7 2011-12-16 10:08:47 PST
Created attachment 119627 [details] requestFileSystem vs. webkitRequestFileSystem for workers
WebKit Review Bot
Comment 8 2011-12-16 11:32:33 PST
Comment on attachment 119627 [details] requestFileSystem vs. webkitRequestFileSystem for workers Rejecting attachment 119627 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/10903806
Dmitry Lomov
Comment 9 2011-12-16 11:41:23 PST
Created attachment 119642 [details] ChangeLog fixed
WebKit Review Bot
Comment 10 2011-12-16 12:42:12 PST
Comment on attachment 119642 [details] ChangeLog fixed Clearing flags on attachment: 119642 Committed r103095: <http://trac.webkit.org/changeset/103095>
WebKit Review Bot
Comment 11 2011-12-16 12:42:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.