Bug 74597

Summary: [Chromium] Enable TestNetscapePlugIn to link for Android
Product: WebKit Reporter: Peter Beverloo <peter>
Component: New BugsAssignee: Peter Beverloo <peter>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, jrg, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66689    
Attachments:
Description Flags
Patch none

Peter Beverloo
Reported 2011-12-15 02:49:37 PST
[Chromium] Enable TestNetscapePlugIn to link
Attachments
Patch (1.62 KB, patch)
2011-12-15 02:52 PST, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Peter Beverloo
Comment 1 2011-12-15 02:52:43 PST
Created attachment 119404 [details] Patch
Peter Beverloo
Comment 2 2011-12-15 02:56:08 PST
After this change, TestNetscapePlugIn.so will be able to link, bringing us up to 2 out of 5 targets. The flag is being set for all targets by this line in common.gypi, this is intentional: http://codesearch.google.com/#OAMlx_jo-ck/src/build/common.gypi&exact_package=chromium&q=common.gypi&type=cs&l=2090 Build errors related to this target (unable to locate crtbegin_so.o) were fixed upstream in the following commit, which has landed in WebKit via the roll yesterday. http://src.chromium.org/viewvc/chrome?view=rev&revision=114216
Peter Beverloo
Comment 3 2011-12-15 03:02:46 PST
Comment on attachment 119404 [details] Patch Thank you!
WebKit Review Bot
Comment 4 2011-12-15 04:35:43 PST
Comment on attachment 119404 [details] Patch Clearing flags on attachment: 119404 Committed r102921: <http://trac.webkit.org/changeset/102921>
WebKit Review Bot
Comment 5 2011-12-15 04:35:47 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.