Bug 74491

Summary: Upstream FileSystemBlackBerry.cpp into WebCore/platform/blackberry
Product: WebKit Reporter: Mary Wu <mawu>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, leo.yang, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73144    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Mary Wu
Reported 2011-12-14 01:43:39 PST
This file upstream was split from bug #73798 per request of Nikolas Zimmermann.
Attachments
Patch (4.84 KB, patch)
2011-12-14 02:00 PST, Mary Wu 		no flags
DetailsFormatted DiffDiff
Patch (2.63 KB, patch)
2011-12-14 19:51 PST, Mary Wu 		no flags
DetailsFormatted DiffDiff
Patch (2.67 KB, patch)
2011-12-14 22:29 PST, Mary Wu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mary Wu
Comment 1 2011-12-14 02:00:01 PST
Created attachment 119179 [details] Patch
Leo Yang
Comment 2 2011-12-14 06:06:14 PST
Why couldn't we share listDirectory with posix? Isn't posix more suitable for the BlackBerry port than efl in this case?
Mary Wu
Comment 3 2011-12-14 19:51:20 PST
yes, thanks for pointing out...update soon
Mary Wu
Comment 4 2011-12-14 19:51:38 PST
Created attachment 119363 [details] Patch
Leo Yang
Comment 5 2011-12-14 20:03:13 PST
Comment on attachment 119363 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119363&action=review Informal review. > Source/WebCore/ChangeLog:8 > + We get most of FileSystem implementations from posix porting. How about changing this line to "Because we are using most of file system implementations from the POSIX porting we only need to implement the left functions." ? I would add an empty line after this line. > Source/WebCore/platform/blackberry/FileSystemBlackBerry.cpp:39 > +bool unloadModule(PlatformModule) > +{ > + return false; Don't we use this API? Why not implement? > Source/WebCore/platform/blackberry/FileSystemBlackBerry.cpp:44 > + return ""; Couldn't we implement this on the BlackBerry/QNX platform?
Mary Wu
Comment 6 2011-12-14 22:11:03 PST
Thanks for comments, Leo. Both interfaces are only used in plugin which seems our plugin porting don't really use them. Maybe in future we need to implement.
Mary Wu
Comment 7 2011-12-14 22:28:20 PST
(In reply to comment #6) > Thanks for comments, Leo. Both interfaces are only used in plugin which seems our plugin porting don't really use them. Maybe in future we need to implement. use/call them
Mary Wu
Comment 8 2011-12-14 22:28:39 PST
commit log update...
Mary Wu
Comment 9 2011-12-14 22:29:16 PST
Created attachment 119379 [details] Patch
Rob Buis
Comment 10 2011-12-15 18:56:30 PST
Comment on attachment 119379 [details] Patch LGTM.
WebKit Review Bot
Comment 11 2011-12-15 20:04:02 PST
Comment on attachment 119379 [details] Patch Clearing flags on attachment: 119379 Committed r103016: <http://trac.webkit.org/changeset/103016>
WebKit Review Bot
Comment 12 2011-12-15 20:04:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.