Bug 74381

Summary: Upstream 3 files into WebCore/platform/blackberry
Product: WebKit Reporter: Mary Wu <mawu>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73144    
Attachments:
Description Flags
Patch
none
Patch none

Mary Wu
Reported 2011-12-12 22:47:42 PST
Upstream 3 files into WebCore/platform/blackberry: ClipboardBlackBerry.cpp/h, PasteboardBlackBerry.cpp
Attachments
Patch (11.41 KB, patch)
2011-12-12 23:10 PST, Mary Wu 		no flags
DetailsFormatted DiffDiff
Patch (11.37 KB, patch)
2011-12-13 19:02 PST, Mary Wu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mary Wu
Comment 1 2011-12-12 23:10:10 PST
Created attachment 118958 [details] Patch
Rob Buis
Comment 2 2011-12-13 13:10:20 PST
Comment on attachment 118958 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118958&action=review Looks very good, can be cleaned up a bit more I think. > Source/WebCore/platform/blackberry/ClipboardBlackBerry.cpp:2 > + * Copyright (C) 2010 Research In Motion Limited. All rights reserved. This was touched in 2011, may as well update that fact. > Source/WebCore/platform/blackberry/PasteboardBlackBerry.cpp:2 > + * Copyright (C) 2009 Research In Motion Limited. All rights reserved. This was touched in 2011, may as well update that fact. > Source/WebCore/platform/blackberry/PasteboardBlackBerry.cpp:91 > + String html = String::fromUTF8(BlackBerry::Platform::Clipboard::readHTML().c_str()); RefPtr<DocumentFragment> fragment could be declared here. > Source/WebCore/platform/blackberry/PasteboardBlackBerry.cpp:96 > + if (fragment) Can write this like if (fragment = createFragmentFromMarkup(frame->document(), html, url, FragmentScriptingNotAllowed)) > Source/WebCore/platform/blackberry/PasteboardBlackBerry.cpp:106 > + if (fragment) { Can write this like if (fragment = createFragmentFromText(context.get(), text))
Mary Wu
Comment 3 2011-12-13 19:02:54 PST
Created attachment 119136 [details] Patch
Rob Buis
Comment 4 2011-12-13 19:21:58 PST
Comment on attachment 119136 [details] Patch Looks great!
WebKit Review Bot
Comment 5 2011-12-13 21:23:02 PST
Comment on attachment 119136 [details] Patch Clearing flags on attachment: 119136 Committed r102739: <http://trac.webkit.org/changeset/102739>
WebKit Review Bot
Comment 6 2011-12-13 21:23:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.